bgpd: backpressure - fix to properly remove dest for bgp under deletion (backport #16368)

[mergify]

Author: Rajasekar Raja [email protected]
Date: Wed Jul 10 20:17:14 2024 -0700

bgpd: backpressure - Improve debuggability

Improve debuggability in backpressure code.

Ticket :#3980988

Signed-off-by: Rajasekar Raja <[email protected]>

Author: Rajasekar Raja [email protected]
Date: Wed Jul 10 16:46:29 2024 -0700

bgpd: backpressure - fix to properly remove dest for bgp under deletion

In case of imported routes (L3vni/vrf leaks), when a bgp instance is
being deleted, the peer->bgp comparision with the incoming bgp to remove
the dest from the pending fifo is wrong. This can lead to the fifo
having stale entries resulting in crash.

Two changes are done here.
 - Instead of pop/push items in list if the struct bgp doesnt match,
   simply iterate the list and remove the expected ones.

 - Corrected the way bgp is fetched from dest rather than relying on
   path_info->peer so that it works for all kinds of routes.

Ticket :#3980988

Signed-off-by: Chirag Shah <chirag @nvidia.com>
Signed-off-by: Rajasekar Raja <[email protected]><hr>This is an automatic backport of pull request #16368 done by [Mergify](https://mergify.com).