Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Ignore errors for frr reload stuff (backport #13891) #16460

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 24, 2024

When we pass an unknown/wrong command and do systemctl reload frr, all processes are killed, and not started up.

Like doing with frr-reload.py, all good:

$ /usr/lib/frr/frr-reload.py --reload /etc/frr/frr.conf
vtysh failed to process new configuration: vtysh (mark file) exited with status 2:
b'line 20: % Unknown command:  neighbor 192.168.10.123 bfd 300 300\n\n'

Closes #13888


This is an automatic backport of pull request #13891 done by Mergify.

When we pass an unknown/wrong command and do `systemctl reload frr`, all processes
are killed, and not started up.

Like doing with frr-reload.py, all good:

```
$ /usr/lib/frr/frr-reload.py --reload /etc/frr/frr.conf
vtysh failed to process new configuration: vtysh (mark file) exited with status 2:
b'line 20: % Unknown command:  neighbor 192.168.10.123 bfd 300 300\n\n'
```

Signed-off-by: Donatas Abraitis <[email protected]>
(cherry picked from commit 243e27a)
@frrbot frrbot bot added the tools label Jul 24, 2024
@ton31337 ton31337 merged commit 5519607 into stable/9.0 Jul 25, 2024
11 of 12 checks passed
@ton31337 ton31337 deleted the mergify/bp/stable/9.0/pr-13891 branch July 25, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant