Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building-frr-for-centos7: fix frr config path error #16515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

victory460
Copy link

According to the building-frr-for-centos7 document, the following errors were found during building:

[root@c7dev frr]# systemctl start frr
Job for frr.service failed because the control process exited with error code. See "systemctl status frr.service" and "journalctl -xe" for details.
[root@c7dev frr]# journalctl -xe
-- Unit frr.service has begun starting up.
Aug 05 10:35:05 c7dev frrinit.sh[76294]: cannot run start: /usr/local/etc/frr/daemons does not exist
Aug 05 10:35:05 c7dev systemd[1]: frr.service: control process exited, code=exited status=1
Aug 05 10:35:05 c7dev systemd[1]: Failed to start FRRouting.
-- Subject: Unit frr.service has failed
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
-- 
-- Unit frr.service has failed.
-- 
-- The result is failed.

@donaldsharp
Copy link
Member

FRR sets sysconfdir based upon what is passed in on configure --sysconfdir=.... The fact that you have /usr/local/etc/frr implies that the sysconfdir passed in was that. What does your config.log say here?

@victory460 victory460 force-pushed the hotfix_centos_build branch from e4916cc to 6b0b14f Compare August 8, 2024 11:52
@github-actions github-actions bot added size/XS and removed size/M labels Aug 8, 2024
@victory460
Copy link
Author

--sysconfdir

FRR sets sysconfdir based upon what is passed in on configure --sysconfdir=.... The fact that you have /usr/local/etc/frr implies that the sysconfdir passed in was that. What does your config.log say here?

Yes, so change it in this PR. Thank a lot.

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to apply such a change for all the examples we have?

@victory460 victory460 force-pushed the hotfix_centos_build branch from 6b0b14f to 1b60b21 Compare August 13, 2024 10:10
@github-actions github-actions bot added the rebase PR needs rebase label Aug 13, 2024
@victory460
Copy link
Author

Do we need to apply such a change for all the examples we have?

Thanks!
Yes, now check and modify all the examples. @donaldsharp @ton31337

@victory460 victory460 force-pushed the hotfix_centos_build branch from 1b60b21 to bb06a47 Compare August 14, 2024 01:02
add --sysconfdir=/etc.

Signed-off-by: xuweiwei <[email protected]>
@victory460 victory460 force-pushed the hotfix_centos_build branch from bb06a47 to d75df74 Compare August 15, 2024 02:03
@donaldsharp
Copy link
Member

can I get an output of your config.log as I asked for? I would like to understand how we got here and this would help and that is why I asked for it

@victory460
Copy link
Author

victory460 commented Aug 16, 2024

can I get an output of your config.log as I asked for? I would like to understand how we got here and this would help and that is why I asked for it

Thanks for your review.
Yes, you can follow the document , it will output this config.log:

.........
datadir='${datarootdir}'
datarootdir='${prefix}/share'
docdir='${datarootdir}/doc/${PACKAGE_TARNAME}'
dvidir='${docdir}'
e_bindir='/usr/bin'
e_frr_libstatedir='/usr/local/var/lib/frr'
e_frr_runstatedir='/usr/local/var/run/frr'
e_frr_sysconfdir='/usr/local/etc/frr'         // by default, it config sysconfdir='/usr/local/etc/frr' 
........

By default, it config sysconfdir='/usr/local/etc/frr' , But it use /etc/frr/ as frr confdir in the document .
If we follow the document without configure --sysconfdir=/etc, it will :

[root@c7dev frr]# systemctl start frr
Job for frr.service failed because the control process exited with error code. See "systemctl status frr.service" and "journalctl -xe" for details.
[root@c7dev frr]# journalctl -xe
-- Unit frr.service has begun starting up.
Aug 05 10:35:05 c7dev frrinit.sh[76294]: cannot run start: /usr/local/etc/frr/daemons does not exist
Aug 05 10:35:05 c7dev systemd[1]: frr.service: control process exited, code=exited status=1
Aug 05 10:35:05 c7dev systemd[1]: Failed to start FRRouting.
-- Subject: Unit frr.service has failed
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
-- 
-- Unit frr.service has failed.
-- 
-- The result is failed.

@donaldsharp

@victory460
Copy link
Author

@donaldsharp

@ton31337 ton31337 requested a review from donaldsharp November 28, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants