Fix IPV6 src-dest route #16686
Fix IPV6 src-dest route #16686
Conversation
Linux kernel currently doesn't support it: zebra[22993]: [HSYZM-HV7HF] Extended Error: IPv6 routes using source address can not use nexthop objects Signed-off-by: Xiao Liang <[email protected]>
| @@ -2361,6 +2361,7 @@ ssize_t netlink_route_multipath_msg_encode(int cmd, struct zebra_dplane_ctx *ctx | |||
| } | |||
|
|
|||
| if ((!fpm && kernel_nexthops_supported() | |||
| && (p->family != AF_INET6 || !src_p) | |||
There was a problem hiding this comment.
Shouldn't we tell the operator about such a thing? Because now we just hide the error/warning being displayed from the kernel, right?
There was a problem hiding this comment.
Not necessary. Instead of using nexthop object, just send RTNL message with plain nexthops, as when no zebra nexthop kernel enable is configured. Kernel is happy with this.
There was a problem hiding this comment.
I think adding a bit of context in the nexthop_groups.rst file to explain this should be sufficient.
There was a problem hiding this comment.
I think adding a bit of context in the nexthop_groups.rst file to explain this should be sufficient.
nexthop_groups.rst is about nexthop-group configured by user, which is a different thing from kernel nexthop objects. Kernel nexthop is sort of internal implementation of zebra. Is it more suitable to put it in zebra.rst?
There was a problem hiding this comment.
sure put it in zebra.rst. I want this documented.
leonshaw
force-pushed
the
fix/ipv6-src-route
branch
from
ef6fd77 to
29193fd
Compare
Signed-off-by: Xiao Liang <[email protected]>
Process IPv6 src-dest routes on nht update, otherwise they are not
installed:
(config)# ipv6 route 1::1/128 from 2::2/128 fe80::1 eth0
(config)# ipv6 route 1::1/128 from 2::3/128 fe80::1 eth0
Signed-off-by: Xiao Liang <[email protected]>
Signed-off-by: Xiao Liang <[email protected]>
leonshaw
force-pushed
the
fix/ipv6-src-route
branch
from
29193fd to
6392442
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Fix issues of IPv6 src-dest route: