bgpd: fix wrong display of default vrf name #16695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following output displays a ((null)) vrf: > rt2> show bgp ipv4 labeled-unicast prefix 172.16.1.1/32 > BGP routing table entry for 172.16.1.1/32, version 2 > Local label: 16 > Paths: (1 available, best FRRouting#1, table default, vrf (null)) > Advertised to non peer-group peers: > 172.16.1.1 > [..] Fix this by displaying the appropriate default vrf name when possible. Signed-off-by: Philippe Guibert <[email protected]>
ton31337
reviewed
Aug 30, 2024
| @@ -12347,7 +12347,9 @@ void route_vty_out_detail_header(struct vty *vty, struct bgp *bgp, | |||
| VRF_DEFAULT_NAME); | |||
| else | |||
| vty_out(vty, ", vrf %s", | |||
| bgp->name); | |||
| (bgp->inst_type == BGP_INSTANCE_TYPE_DEFAULT) | |||
There was a problem hiding this comment.
This condition is useless, it's checked above, right? What I suggest is replacing these checks at all using bgp->name_pretty. In this case no need to check if it's a default instance and/or VRF/view instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following output displays a ((null)) vrf:
Fix this by displaying the appropriate default vrf name when possible.