babeld: Add MBZ and Reserved field checking #16735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zmw12306 <[email protected]>
zmw12306
force-pushed
the
babel_nonzeroMBZ
branch
from
af11e08 to
9731902
Compare
donaldsharp
reviewed
Sep 4, 2024
| @@ -144,7 +144,12 @@ static bool parse_update_subtlv(const unsigned char *a, int alen, | |||
| "Received Mandatory bit set but this FRR version is not prepared to handle it at this point"); | |||
| return true; | |||
| } else if (type == SUBTLV_PADN) { | |||
| /* Nothing. */ | |||
| for (int j = 0; j < len; j++) { | |||
| if (a[i + j + 2] != 0) { | |||
There was a problem hiding this comment.
Please no magic values. Please go through the entire commit and fix the magic values to a define.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to RFC 8966:
https://www.rfc-editor.org/rfc/rfc8966.html#name-padn
PadN
PadN TLV: MBZ must be zero
PadN SubTLV: MBZ must be zero
according to RFC 8966:
Acknowledgment Request
IHU
Router-Id
Next Hop
Seqno Request
'Reserved' field should be sent as 0