Add some test cases, and some ability to see what is going on in zebra #16878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I changed all_protocol_startup locally and it runs fine. I'll need to investigate when I get a chance |
donaldsharp
force-pushed
the
increased_test_cover
branch
from
af1d337 to
7c6ee1b
Compare
Jafaral
reviewed
Sep 20, 2024
Comment on lines
+1725
to
+1728
| print("\n\n** Verifying some interface code") | ||
| print("************************************\n") |
There was a problem hiding this comment.
I’m not interested in switching the test over to step.
donaldsharp
force-pushed
the
increased_test_cover
branch
from
7c6ee1b to
59a8a5f
Compare
donaldsharp
force-pushed
the
increased_test_cover
branch
from
59a8a5f to
33d1999
Compare
donaldsharp
force-pushed
the
increased_test_cover
branch
2 times, most recently
from
1b01aed to
b8494d5
Compare
For interface config: shutdown mpls multicast These states were never being shown in output, let's show it. Signed-off-by: Donald Sharp <[email protected]>
I noticed that there was some missed code coverage in zebra. multicast [enable|disable] and show interface description vrf all Add a bit to get it covered. Signed-off-by: Donald Sharp <[email protected]>
The functions: if_get_flags if_flags_update if_flags_mangle are never invoked from a linux netlink build. Put a #ifdef around those functions so that they are not included on the linux build as that they are not needed there. Signed-off-by: Donald Sharp <[email protected]>
Noticed that we were not really attempting to even test large swaths of our snmp infrastructure. Let's load up some very simple configs for those daemons that FRR supports and ensure that SNMP is working to some extent. Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
These functions are not being used. Let's just remove them from our code base. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
increased_test_cover
branch
from
b8494d5 to
67526c4
Compare
Jafaral
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.