zebra snmp fixes (backport #16918) #16921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The snmp walk of the zebra rib was skipping entries because in_addr_cmp was replaced with a prefix_cmp which worked slightly differently causing parts of the zebra rib tree to be skipped. Signed-off-by: Donald Sharp <[email protected]> (cherry picked from commit ecd9d44)
Signed-off-by: Donald Sharp <[email protected]> (cherry picked from commit 659cd66)
Report the routes metric in IPFORWARDMETRIC1 and return
-1 for the other metrics as required by the IP-FORWARD-MIB.
inetCidrRouteMetric2 OBJECT-TYPE
SYNTAX Integer32
MAX-ACCESS read-create
STATUS current
DESCRIPTION
"An alternate routing metric for this route. The
semantics of this metric are determined by the routing-
protocol specified in the route's inetCidrRouteProto
value. If this metric is not used, its value should be
set to -1."
DEFVAL { -1 }
::= { inetCidrRouteEntry 13 }
I've included metric2 but it's the same for all of them.
Signed-off-by: Donald Sharp <[email protected]>
(cherry picked from commit e41ae0a)
Add missing isis and eigrp proto translations. Signed-off-by: Donald Sharp <[email protected]> (cherry picked from commit f53dde0)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was playing with snmp and noticed some issues with zebra's implementation of it.
a) snmp walk was wrong. Whomever wrote this found a new and interesting way to make something simple hard. Further work should be done to optimize this, just putting this back into working order since I broke it in 2019
b) Who would think to walk the individual bytes of a struct to set them to 0 in a loop when memset is available?
c) Metrics are not being reported at all. Let's return them
d) Some missing proto translations. The values are weird so we don't get everything.
This is an automatic backport of pull request #16918 done by Mergify.