Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix calloc warning on recent compiler #16958

Merged
merged 1 commit into from
Sep 30, 2024
Merged

lib: fix calloc warning on recent compiler #16958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/elf_py.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1307,7 +1307,7 @@ static PyObject *elffile_load(PyTypeObject *type, PyObject *args,
}
#endif

w->sects = calloc(sizeof(PyObject *), w->ehdr->e_shnum);
w->sects = calloc(w->ehdr->e_shnum, sizeof(PyObject *));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this code ever work? or was it never used?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calloc always multiples one number by the other. This is simple multiplication rules. The compiler is just asking for the number of elements * the size to be in a specific order

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose. :)

w->n_sect = w->ehdr->e_shnum;

return (PyObject *)w;
Expand Down
Loading