zebra: On startup actually allow for nhe's to be early #16960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hate this one. Thinking about it some more |
donaldsharp
force-pushed
the
zebra_nhg_startup_issue
branch
from
87cd8a0 to
9ddd39d
Compare
|
I rewrote the whole approach. I like this better |
donaldsharp
force-pushed
the
zebra_nhg_startup_issue
branch
from
9ddd39d to
bbf6307
Compare
donaldsharp
force-pushed
the
zebra_nhg_startup_issue
branch
from
bbf6307 to
d40a014
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
donaldsharp
force-pushed
the
zebra_nhg_startup_issue
branch
from
d40a014 to
54511bd
Compare
donaldsharp
force-pushed
the
zebra_nhg_startup_issue
branch
from
54511bd to
d032ecb
Compare
mjstapp
reviewed
Oct 14, 2024
zebra/rib.h
Outdated
| @@ -637,6 +637,7 @@ extern uint32_t rt_table_main_id; | |||
| void route_entry_dump_nh(const struct route_entry *re, const char *straddr, | |||
| const struct vrf *re_vrf, | |||
| const struct nexthop *nexthop); | |||
| extern void zebra_main_router_started(void); | |||
There was a problem hiding this comment.
hmm - header file - maybe this should be in zebra_router.h? that's a little more general-purpose
zebra/main.c
Outdated
| void zebra_main_router_started(void) | ||
| { | ||
| /* After we have successfully acquired the pidfile, we can be sure | ||
| * about being the only copy of zebra process, which is submitting |
There was a problem hiding this comment.
this copied-over comment is a little confusing, now that we're not in the context of main() ?
it'd be clearer if it aligned with the comment around the caller - that this is being called once zebra has requested a bunch of data from the OS or dataplane?
There was a problem hiding this comment.
fixed as per slack conversation
donaldsharp
force-pushed
the
zebra_nhg_startup_issue
branch
from
d032ecb to
4b66a36
Compare
Currently zebra starts the graceful restart timer as well as allows connections from clients before all data is read in from the kernel as well as the possiblity of allowing client connections before this happens as well. Let's move the graceful restart timer start till after this is done as well as not allowing client connections till then as well. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
zebra_nhg_startup_issue
branch
from
4b66a36 to
9e74dda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent commits have moved zebra's nexthop group cache entries to be figured out after the dplane has started up. As such this leaves us with a situation where the cache entries startup time can be/is greater than the startup time for the purposes of graceful restart. Just notice that we are in startup mode and do the right thing.