zebra: remove useless code #17166
Merged
zebra: remove useless code #17166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anlan_cs <[email protected]>
ton31337
approved these changes
Oct 20, 2024
|
@eqvinox could you take a look at it? |
mjstapp
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
I think this is fine - maybe the v6 src was being used in an earlier version, or a debug sometime?
But ... it'd be more friendly to have some description of the thinking behind these kinds of cleanups. It takes more work than it should for the reviewers to inspect the change and try to figure out what was intended...
|
I agree with @mjstapp , please make it clear what you are changing and why. see #17180 (comment) |
|
At that time of reviewing code, my idea is simple: no places use this variable, so they should be removed... @Jafaral |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.