bgpd: fix crash when polling bgp4v2PathAttrTable #17245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdumontet6WIND
force-pushed
the
fix1
branch
2 times, most recently
from
4823849 to
87355ce
Compare
we have
(gdb) p *path->attr->aspath
$1 = {refcnt = 3, segments = 0x0, json = 0x0, str = 0x55723d0b7470 "", str_len = 0, asnotation = ASNOTATION_PLAIN}
It looks like this aspath is empty, resulting in a size 0 and NULL pointer for path->attr->aspath->segments which leads to the SIGSEGV
fixe: return 0 when segments is null.
Signed-off-by: Francois Dumontet <[email protected]>
|
not linked with that fix |
|
Is this happening for iBGP stuff? |
|
@Mergifyio backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0 |
✅ Backports have been created
|
This was referenced Oct 29, 2024
riw777
added a commit
that referenced
this pull request
Oct 29, 2024
bgpd: fix crash when polling bgp4v2PathAttrTable (backport #17245)
riw777
added a commit
that referenced
this pull request
Oct 29, 2024
bgpd: fix crash when polling bgp4v2PathAttrTable (backport #17245)
riw777
added a commit
that referenced
this pull request
Oct 29, 2024
bgpd: fix crash when polling bgp4v2PathAttrTable (backport #17245)
riw777
added a commit
that referenced
this pull request
Oct 29, 2024
bgpd: fix crash when polling bgp4v2PathAttrTable (backport #17245)
riw777
added a commit
that referenced
this pull request
Oct 29, 2024
bgpd: fix crash when polling bgp4v2PathAttrTable (backport #17245)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have
(gdb) p *path->attr->aspath
$1 = {refcnt = 3, segments = 0x0, json = 0x0, str = 0x55723d0b7470 "", str_len = 0, asnotation = ASNOTATION_PLAIN}
It looks like this aspath is empty, resulting in a size 0 and NULL pointer for path->attr->aspath->segments which leads to the SIGSEGV
fixe: return 0 when segments is null.