-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement SBFD #17336
base: master
Are you sure you want to change the base?
implement SBFD #17336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good ... I think we need a topo test for this, though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be broken into multiple commits, and this also needs a topo test.
a) This needs to be broken up into multiple commits. 4k lines to review is impossible. Break it down into small logical bits of work, this will never be reviewed otherwise Without some major changes this is dead in the water. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: wumu.zsl <[email protected]>
Signed-off-by: wumu.zsl <[email protected]>
Signed-off-by: wumu.zsl <[email protected]>
Signed-off-by: wumu.zsl <[email protected]>
Signed-off-by: wumu.zsl <[email protected]>
…heck for existing bfd Xpath callbacks Signed-off-by: wumu.zsl <[email protected]>
Signed-off-by: wumu.zsl <[email protected]>
Signed-off-by: wumu.zsl <[email protected]>
… of sbfd pks are supported: init packet and echo packet Signed-off-by: wumu.zsl <[email protected]>
Signed-off-by: wumu.zsl <[email protected]>
Signed-off-by: wumu.zsl <[email protected]>
…sbfd pkts Signed-off-by: wumu.zsl <[email protected]>
Signed-off-by: wumu.zsl <[email protected]>
… use bfdname as a key to track bfd state Signed-off-by: wumu.zsl <[email protected]>
Signed-off-by: wumu.zsl <[email protected]>
Signed-off-by: wumu.zsl <[email protected]>
Signed-off-by: wumu.zsl <[email protected]>
Looks like the docs are in, but we still need a topo test ... |
Yes Russ White, Thanks for reviewing the code. The topo test in ongoing, I will update the PR later. |
implementing the SBFD feature (RFC7880, RFC7881) in FRR.
What is the motivation for this PR?
The PhoenixWing project aims to implement SRv6 features into the SONiC community. In PhoenixWing traffic engineering case, we use SBFD to protect SRv6 TE paths.
How did you do it?
SBFD HLD in SoNiC community: sonic-net/SONiC#1766
use SBFD to protect TE path, two types of configs are supported:
configure terminal->
bfd ->
peer X::X bfd-mode sbfd-echo bfd-name name local-address X::X encap-type SRv6 encap-data X::X source-ipv6 X::X
2.1) local config:
configure terminal->
bfd ->
peer X::X bfd-mode sbfd-init bfd-name name local-address X::X encap-type SRv6 encap-data X::X source-ipv6 X::X remote-discr 12345
2.2) remote config:
configure terminal ->
bfd ->
sbfd reflector source-address X::X discriminator 12345