-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd: Fix for match source-protocol in route-map for redistribute cmd (backport) #17402
Merged
riw777
merged 1 commit into
FRRouting:stable/10.1
from
opensourcerouting:fix/backport_031d4271018e827010abfa8f3ecfe60bbf1de21d_10.1
Nov 12, 2024
Merged
bgpd: Fix for match source-protocol in route-map for redistribute cmd (backport) #17402
riw777
merged 1 commit into
FRRouting:stable/10.1
from
opensourcerouting:fix/backport_031d4271018e827010abfa8f3ecfe60bbf1de21d_10.1
Nov 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Mergifyio backport stable/10.0 stable/9.1 stable/9.0 |
✅ Backports have been created
|
A redistribute cmd can have a route-map attached to it and adding the match source-protocol to that route-map means BGP to filter which protocol routes to accept among the bunch of routes zebra is sending. Fixing this since this wasnt implemented earlier. Ticket :#4119692 Signed-off-by: Donald Sharp <[email protected]> Signed-off-by: Rajasekar Raja <[email protected]> (cherry picked from commit 68358c0) Signed-off-by: Donatas Abraitis <[email protected]>
ton31337
force-pushed
the
fix/backport_031d4271018e827010abfa8f3ecfe60bbf1de21d_10.1
branch
from
November 10, 2024 17:11
8246d9f
to
f93e5aa
Compare
riw777
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
This was referenced Nov 12, 2024
Jafaral
added a commit
that referenced
this pull request
Nov 12, 2024
bgpd: Fix for match source-protocol in route-map for redistribute cmd (backport) (backport #17402)
ton31337
deleted the
fix/backport_031d4271018e827010abfa8f3ecfe60bbf1de21d_10.1
branch
November 12, 2024 18:12
Jafaral
added a commit
that referenced
this pull request
Nov 12, 2024
bgpd: Fix for match source-protocol in route-map for redistribute cmd (backport) (backport #17402)
ton31337
added a commit
that referenced
this pull request
Nov 13, 2024
bgpd: Fix for match source-protocol in route-map for redistribute cmd (backport) (backport #17402)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A redistribute cmd can have a route-map attached to it and adding the match source-protocol to that route-map means BGP to filter which protocol routes to accept among the bunch of routes zebra is sending.
Fixing this since this wasnt implemented earlier.
Ticket :#4119692
Signed-off-by: Donald Sharp [email protected]
Signed-off-by: Rajasekar Raja [email protected]
(cherry picked from commit 68358c0)