bgpd : backpressure - Fix to pop items off zebra_announce FIFO for few EVPN triggers #17432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be backported to previous releases as well.. Fixes: a07df6f |
ton31337
reviewed
Nov 15, 2024
bgpd/bgp_evpn.c
Outdated
| struct bgp_dest *dest = NULL; | ||
| struct bgp_dest *dest_next = NULL; | ||
|
|
||
| if (!vpn) |
There was a problem hiding this comment.
In what case can this be NULL? Because cleanup_vni_on_disable() is calling this function with a non-NULL argument which is already dereferenced.
There was a problem hiding this comment.
a mistake ... removed it now
…w EVPN triggers
In cases such as 'no advertise-all-vni' and L2 VNI DELETE, we need to
pop all the VPN routes present in the bgp_zebra_announce FIFO yet to
be processed regardless of VNI is configured or not.
NOTE: NO need to pop the VPN routes in two cases
1) In free_vni_entry
- Called by bgp_free()->bgp_evpn_cleanup().
- Since bgp_delete is called before bgp_free and we pop all the dest
pertaining to bgp under delete.
2) evpn_delete_vni() when user configures "no vni" since the withdraw
of all routes happen in normal cycle.
Fixes: a07df6f
("bgpd : backpressure - Handle BGP-Zebra(EPVN) Install evt Creation")
Ticket :#4163611
Signed-off-by: Rajasekar Raja <[email protected]>
raja-rajasekar
force-pushed
the
rajasekarr/evpn_pop_items_bp
branch
from
b8c88a5 to
898852f
Compare
|
@Mergifyio backport stable/10.2 stable/10.1 |
✅ Backports have been created
|
Jafaral
added a commit
that referenced
this pull request
Nov 17, 2024
bgpd : backpressure - Fix to pop items off zebra_announce FIFO for few EVPN triggers (backport #17432)
ton31337
added a commit
that referenced
this pull request
Nov 19, 2024
bgpd : backpressure - Fix to pop items off zebra_announce FIFO for few EVPN triggers (backport #17432)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases such as 'no advertise-all-vni' and L2 VNI DELETE, we need to pop all the VPN routes present in the bgp_zebra_announce FIFO yet to be processed regardless of VNI is configured or not.
NOTE: NO need to pop the VPN routes in two cases
Fixes: a07df6f
("bgpd : backpressure - Handle BGP-Zebra(EPVN) Install evt Creation")
Ticket :#4163611