Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: Fix compilation warning for rfapi code #17454

Closed
wants to merge 1 commit into from
Closed

bgpd: Fix compilation warning for rfapi code #17454

wants to merge 1 commit into from

Conversation

ton31337
Copy link
Member

No description provided.

@ton31337
bgpd: Fix compilation warning for rfapi code
06987ee 
bgpd/rfapi/rfapi_rib.c:1800:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
         prefix_time = (time_t)trn->info;

Signed-off-by: Donatas Abraitis <[email protected]>
@frrbot frrbot bot added the bgp label Nov 18, 2024
donaldsharp
donaldsharp requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@donaldsharp donaldsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe this is correct, here is where the trn->info pointer is set:

trn->info = (void *)(uintptr_t)monotime(NULL);

effectively they are taking a uint64_t and treating it as a pointer. Your code is dereferencing that pointer right?

@ton31337 ton31337 closed this Nov 19, 2024
@ton31337 ton31337 deleted the fix/compile_warning_time_t_casting branch November 19, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldsharp donaldsharp donaldsharp requested changes

Assignees
No one assigned
Labels
bgp master size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ton31337 @donaldsharp