zebra: fix EVPN check vxlan oper up in vlan mapping #17483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When VLAN-VNI mapping is updated, do not set the L2VNI up event if the associated VXLAN device is not up. This may result in bgp synced remote routes to skip installing in Zebra and onwards (Kernel). Ticket: #4139506 Signed-off-by: Chirag Shah <[email protected]>
Ticket: #4139506 Signed-off-by: Chirag Shah <[email protected]>
Ticket: #4139506 Signed-off-by: Chirag Shah <[email protected]>
Ticket: #4127810
Testing:
2024-11-20T01:52:10.073 frr_zebra:netlink_neigh_update_msg_encode
{'mac': '00:00:00:00:00:00', 'ip': '27.0.0.4', 'nhg': 0, 'flags': 2,
'state': 192, 'family': 'bridge', 'type': 0, 'op': 23}
Signed-off-by: Chirag Shah <[email protected]>
python3 -m black tools/frr_babeltrace.py Signed-off-by: Chirag Shah <[email protected]>
chiragshah6
force-pushed
the
evpn_dev4
branch
from
1ad2479 to
814a89f
Compare
|
Fixed the appropriate style issues. |
|
Can we fix frrbot also? |
@ton31337 I fixed whole bunch, the others we should leave as is, the remaining ones are more readable and not expanded in single lines as the "black" tool reported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is when bridge flap lead to failure of Type-2/Type-3 route installation.
Upon VxLAN device flap, the associated vlan-vni mapping is processed
before the VxLAN device up netlink notification.
Fix:
When VLAN-VNI mapping is updated, do not set the L2VNI up event
if the associated VXLAN device is not up. This may result in bgp
synced remote routes to skip installing in Zebra and onwards (Kernel).
Signed-off-by: Chirag Shah [email protected]