Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: Fix Graceful-Restart for peer-groups #17501

Merged
merged 3 commits into from
Nov 26, 2024
Merged

bgpd: Fix Graceful-Restart for peer-groups #17501

merged 3 commits into from
Nov 26, 2024

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Nov 25, 2024 •
edited
Loading

Closes #17496

@ton31337
bgpd: Fix graceful-restart for peer-groups
0a85b1b 
Slipped somehow that peer-groups with GR is just completely broken, but it was
working before.

Strikes again, that we MUST have more and more topotests.

Fixes: 15403f5 ("bgpd: Streamline GR config, act on change immediately")

Signed-off-by: Donatas Abraitis <[email protected]>
@ton31337
bgpd: Use gracefulRestart JSON field
ee5893f 
Deprecate gracefulRestartCapability which is inconsistent with an existing
format if advertised and received are printed.

Signed-off-by: Donatas Abraitis <[email protected]>
@ton31337
tests: Check if GR settings are inherited for peer-groups
a4bfa8c 
Convert to unified config also.

Signed-off-by: Donatas Abraitis <[email protected]>
@frrbot frrbot bot added bgp bugfix tests Topotests, make check, etc labels Nov 25, 2024
@ton31337 ton31337 mentioned this pull request Nov 25, 2024
Closed
2 tasks
riw777
riw777 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit 842da0d into FRRouting:master Nov 26, 2024
18 checks passed
@ton31337 ton31337 deleted the fix/gr_peer-groups branch November 26, 2024 15:59
@ton31337
Copy link
Member Author

@Mergifyio backport stable/10.2

@mergify Mergify
Copy link

mergify bot commented Nov 26, 2024 •
edited
Loading

backport stable/10.2

✅ Backports have been created

@mergify mergify bot mentioned this pull request Nov 26, 2024
Merged
ton31337 added a commit that referenced this pull request Nov 26, 2024
@ton31337
Merge pull request #17517 from FRRouting/mergify/bp/stable/10.2/pr-17501
1cbd065 
bgpd: Fix Graceful-Restart for peer-groups (backport #17501)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 approved these changes

Assignees
No one assigned
Labels
backport bgp bugfix master size/L tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bgpd: "Per peer-group graceful-restart configuration is not yet supported"
2 participants
@ton31337 @riw777