bgpd: allow batch handling of peer shutdown/failure #17505
frrbot / frrbot
completed
Dec 3, 2024 in 35s
Style and/or linter errors found
Style and/or linter errors found
Details
Thanks for your contribution to FRR!
Pylint found errors in source files changed by this PR:
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer1/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer1/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer1/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer1/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer1/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer1/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer1/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer10/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer10/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer10/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer10/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer10/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer10/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer10/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer11/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer11/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer11/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer11/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer11/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer11/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer11/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer12/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer12/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer12/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer12/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer12/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer12/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer12/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer13/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer13/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer13/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer13/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer13/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer13/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer13/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer14/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer14/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer14/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer14/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer14/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer14/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer14/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer15/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer15/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer15/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer15/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer15/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer15/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer15/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer16/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer16/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer16/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer16/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer16/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer16/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer16/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer17/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer17/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer17/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer17/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer17/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer17/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer17/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer18/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer18/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer18/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer18/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer18/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer18/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer18/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer19/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer19/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer19/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer19/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer19/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer19/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer19/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer2/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer2/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer2/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer2/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer2/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer2/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer2/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer20/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer20/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer20/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer20/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer20/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer20/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer20/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer3/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer3/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer3/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer3/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer3/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer3/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer3/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer4/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer4/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer4/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer4/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer4/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer4/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer4/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer5/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer5/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer5/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer5/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer5/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer5/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer5/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer6/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer6/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer6/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer6/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer6/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer6/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer6/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer7/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer7/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer7/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer7/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer7/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer7/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer7/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer8/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer8/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer8/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer8/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer8/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer8/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer8/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Pylint report for my_frr-232337/tests/topotests/bgp_peer_shut/peer9/exa-send.py:
************* Module exa-send
my_frr-232337/tests/topotests/bgp_peer_shut/peer9/exa-send.py:24: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer9/exa-send.py:32: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer9/exa-send.py:40: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer9/exa-send.py:48: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer9/exa-send.py:55: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
my_frr-232337/tests/topotests/bgp_peer_shut/peer9/exa-send.py:59: error (E1307, bad-string-format-type, ) Argument 'builtins.float' does not match format type 'i'
Click for style suggestions
diff --git a/bgpd/bgp_fsm.c b/bgpd/bgp_fsm.c
index 342d1ca77..468ae0dbd 100644
--- a/bgpd/bgp_fsm.c
+++ b/bgpd/bgp_fsm.c
@@ -1272,8 +1272,7 @@ void bgp_fsm_change_status(struct peer_connection *connection,
* (or Deleted).
*/
if (!CHECK_FLAG(peer->flags, PEER_FLAG_CLEARING_BATCH) &&
- !work_queue_is_scheduled(peer->clear_node_queue) &&
- status != Deleted)
+ !work_queue_is_scheduled(peer->clear_node_queue) && status != Deleted)
BGP_EVENT_ADD(connection, Clearing_Completed);
}
diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index 245d3ee62..5ef5c1fbe 100644
--- a/bgpd/bgp_route.c
+++ b/bgpd/bgp_route.c
@@ -6234,29 +6234,24 @@ next_dest:
continue;
/* graceful restart STALE flag set. */
- if (((CHECK_FLAG(pi->peer->sflags, PEER_STATUS_NSF_WAIT)
- && pi->peer->nsf[afi][safi])
- || CHECK_FLAG(pi->peer->af_sflags[afi][safi],
- PEER_STATUS_ENHANCED_REFRESH))
- && !CHECK_FLAG(pi->flags, BGP_PATH_STALE)
- && !CHECK_FLAG(pi->flags, BGP_PATH_UNUSEABLE))
+ if (((CHECK_FLAG(pi->peer->sflags, PEER_STATUS_NSF_WAIT) &&
+ pi->peer->nsf[afi][safi]) ||
+ CHECK_FLAG(pi->peer->af_sflags[afi][safi], PEER_STATUS_ENHANCED_REFRESH)) &&
+ !CHECK_FLAG(pi->flags, BGP_PATH_STALE) &&
+ !CHECK_FLAG(pi->flags, BGP_PATH_UNUSEABLE))
bgp_path_info_set_flag(dest, pi, BGP_PATH_STALE);
else {
/* If this is an EVPN route, process for
* un-import. */
if (safi == SAFI_EVPN)
- bgp_evpn_unimport_route(
- bgp, afi, safi,
- bgp_dest_get_prefix(dest), pi);
+ bgp_evpn_unimport_route(bgp, afi, safi, bgp_dest_get_prefix(dest),
+ pi);
/* Handle withdraw for VRF route-leaking and L3VPN */
- if (SAFI_UNICAST == safi
- && (bgp->inst_type == BGP_INSTANCE_TYPE_VRF ||
- bgp->inst_type == BGP_INSTANCE_TYPE_DEFAULT)) {
- vpn_leak_from_vrf_withdraw(bgp_get_default(),
- bgp, pi);
+ if (SAFI_UNICAST == safi && (bgp->inst_type == BGP_INSTANCE_TYPE_VRF ||
+ bgp->inst_type == BGP_INSTANCE_TYPE_DEFAULT)) {
+ vpn_leak_from_vrf_withdraw(bgp_get_default(), bgp, pi);
}
- if (SAFI_MPLS_VPN == safi &&
- bgp->inst_type == BGP_INSTANCE_TYPE_DEFAULT) {
+ if (SAFI_MPLS_VPN == safi && bgp->inst_type == BGP_INSTANCE_TYPE_DEFAULT) {
vpn_leak_to_vrf_withdraw(pi);
}
@@ -6277,15 +6272,14 @@ done:
/* If there are still dests to process, reschedule. */
if (bgp_clearing_batch_dests_present(cinfo)) {
if (bgp_debug_neighbor_events(NULL))
- zlog_debug("%s: Batch %p: Rescheduled after processing %d dests",
- __func__, cinfo, counter);
+ zlog_debug("%s: Batch %p: Rescheduled after processing %d dests", __func__,
+ cinfo, counter);
- event_add_event(bm->master, bgp_clear_batch_dests_task, cinfo,
- 0, &cinfo->t_sched);
+ event_add_event(bm->master, bgp_clear_batch_dests_task, cinfo, 0, &cinfo->t_sched);
} else {
if (bgp_debug_neighbor_events(NULL))
- zlog_debug("%s: Batch %p: Done after processing %d dests",
- __func__, cinfo, counter);
+ zlog_debug("%s: Batch %p: Done after processing %d dests", __func__, cinfo,
+ counter);
bgp_clearing_batch_completed(cinfo);
}
@@ -6295,8 +6289,7 @@ done:
/*
* Walk a single table for batch peer clearing processing
*/
-static void clear_batch_table_helper(struct bgp_clearing_info *cinfo,
- struct bgp_table *table)
+static void clear_batch_table_helper(struct bgp_clearing_info *cinfo, struct bgp_table *table)
{
struct bgp_dest *dest;
bool force = (cinfo->bgp->process_queue == NULL);
@@ -6343,9 +6336,8 @@ static void clear_batch_table_helper(struct bgp_clearing_info *cinfo,
if (examined > 0) {
if (bgp_debug_neighbor_events(NULL))
- zlog_debug("%s: %s/%s: examined %u, queued %u",
- __func__, afi2str(table->afi),
- safi2str(table->safi), examined, queued);
+ zlog_debug("%s: %s/%s: examined %u, queued %u", __func__,
+ afi2str(table->afi), safi2str(table->safi), examined, queued);
}
}
@@ -6363,16 +6355,15 @@ static void clear_batch_rib_helper(struct bgp_clearing_info *cinfo)
FOREACH_AFI_SAFI (afi, safi) {
/* Identify table to be examined */
- if (safi != SAFI_MPLS_VPN && safi != SAFI_ENCAP &&
- safi != SAFI_EVPN) {
+ if (safi != SAFI_MPLS_VPN && safi != SAFI_ENCAP && safi != SAFI_EVPN) {
table = cinfo->bgp->rib[afi][safi];
if (!table)
continue;
clear_batch_table_helper(cinfo, table);
} else {
- for (dest = bgp_table_top(cinfo->bgp->rib[afi][safi]);
- dest; dest = bgp_route_next(dest)) {
+ for (dest = bgp_table_top(cinfo->bgp->rib[afi][safi]); dest;
+ dest = bgp_route_next(dest)) {
table = bgp_dest_get_bgp_table_info(dest);
if (!table)
continue;
@@ -6394,16 +6385,14 @@ static void clear_batch_rib_helper(struct bgp_clearing_info *cinfo)
void bgp_clear_route_batch(struct bgp_clearing_info *cinfo)
{
if (bgp_debug_neighbor_events(NULL))
- zlog_debug("%s: BGP %s, batch %p", __func__,
- cinfo->bgp->name_pretty, cinfo);
+ zlog_debug("%s: BGP %s, batch %p", __func__, cinfo->bgp->name_pretty, cinfo);
/* Walk the rib, checking the peers in the batch */
clear_batch_rib_helper(cinfo);
/* If we found some prefixes, schedule a task to begin work. */
if (bgp_clearing_batch_dests_present(cinfo))
- event_add_event(bm->master, bgp_clear_batch_dests_task, cinfo,
- 0, &cinfo->t_sched);
+ event_add_event(bm->master, bgp_clear_batch_dests_task, cinfo, 0, &cinfo->t_sched);
/* NB -- it's the caller's job to clean up, release refs, etc. if
* we didn't find any dests
diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c
index 728934ca2..7f0adeb54 100644
--- a/bgpd/bgpd.c
+++ b/bgpd/bgpd.c
@@ -100,8 +100,8 @@ DECLARE_LIST(bgp_clearing_destlist, struct bgp_clearing_dest, link);
static int peer_clearing_hash_cmp(const struct peer *p1, const struct peer *p2);
static uint32_t peer_clearing_hashfn(const struct peer *p1);
-DECLARE_HASH(bgp_clearing_hash, struct peer, clear_hash_link,
- peer_clearing_hash_cmp, peer_clearing_hashfn);
+DECLARE_HASH(bgp_clearing_hash, struct peer, clear_hash_link, peer_clearing_hash_cmp,
+ peer_clearing_hashfn);
/* BGP process wide configuration. */
static struct bgp_master bgp_master;
@@ -2707,8 +2707,7 @@ int peer_delete(struct peer *peer)
/* Ensure the peer is removed from the connection error list */
frr_with_mutex (&bgp->peer_errs_mtx) {
if (bgp_peer_conn_errlist_anywhere(peer->connection))
- bgp_peer_conn_errlist_del(&bgp->peer_conn_errlist,
- peer->connection);
+ bgp_peer_conn_errlist_del(&bgp->peer_conn_errlist, peer->connection);
}
if (CHECK_FLAG(peer->sflags, PEER_STATUS_NSF_WAIT))
@@ -4138,8 +4137,7 @@ int bgp_delete(struct bgp *bgp)
*/
frr_with_mutex (&bgp->peer_errs_mtx) {
do {
- connection = bgp_peer_conn_errlist_pop(
- &bgp->peer_conn_errlist);
+ connection = bgp_peer_conn_errlist_pop(&bgp->peer_conn_errlist);
} while (connection != NULL);
}
@@ -4166,7 +4164,7 @@ int bgp_delete(struct bgp *bgp)
while ((cinfo = bgp_clearing_info_pop(&bgp->clearing_list)) != NULL)
bgp_clearing_batch_completed(cinfo);
-/* TODO - Other memory may need to be freed - e.g., NHT */
+ /* TODO - Other memory may need to be freed - e.g., NHT */
#ifdef ENABLE_BGP_VNC
if (!IS_BGP_INSTANCE_HIDDEN(bgp))
@@ -8932,8 +8930,7 @@ static uint32_t peer_clearing_hashfn(const struct peer *p1)
* Free a clearing batch: this really just does the memory cleanup; the
* clearing code is expected to manage the peer, dest, table, etc refcounts
*/
-static void bgp_clearing_batch_free(struct bgp *bgp,
- struct bgp_clearing_info **pinfo)
+static void bgp_clearing_batch_free(struct bgp *bgp, struct bgp_clearing_info **pinfo)
{
struct bgp_clearing_info *cinfo = *pinfo;
struct bgp_clearing_dest *destinfo;
@@ -9019,8 +9016,7 @@ static void bgp_clearing_batch_end(struct bgp *bgp)
}
/* Check whether a dest's peer is relevant to a clearing batch */
-bool bgp_clearing_batch_check_peer(struct bgp_clearing_info *cinfo,
- const struct peer *peer)
+bool bgp_clearing_batch_check_peer(struct bgp_clearing_info *cinfo, const struct peer *peer)
{
struct peer *p;
@@ -9073,13 +9069,11 @@ void bgp_clearing_batch_completed(struct bgp_clearing_info *cinfo)
/*
* Add a prefix/dest to a clearing batch
*/
-void bgp_clearing_batch_add_dest(struct bgp_clearing_info *cinfo,
- struct bgp_dest *dest)
+void bgp_clearing_batch_add_dest(struct bgp_clearing_info *cinfo, struct bgp_dest *dest)
{
struct bgp_clearing_dest *destinfo;
- destinfo = XCALLOC(MTYPE_CLEARING_BATCH,
- sizeof(struct bgp_clearing_dest));
+ destinfo = XCALLOC(MTYPE_CLEARING_BATCH, sizeof(struct bgp_clearing_dest));
destinfo->dest = dest;
bgp_clearing_destlist_add_tail(&cinfo->destlist, destinfo);
@@ -9149,8 +9143,7 @@ static void bgp_process_conn_error(struct event *event)
frr_with_mutex (&bgp->peer_errs_mtx) {
connection = bgp_peer_conn_errlist_pop(&bgp->peer_conn_errlist);
- list_count =
- bgp_peer_conn_errlist_count(&bgp->peer_conn_errlist);
+ list_count = bgp_peer_conn_errlist_count(&bgp->peer_conn_errlist);
}
/* If we have multiple peers with errors, try to batch some
@@ -9164,16 +9157,14 @@ static void bgp_process_conn_error(struct event *event)
peer = connection->peer;
if (bgp_debug_neighbor_events(peer))
- zlog_debug("%s [Event] BGP error %d on fd %d",
- peer->host, connection->connection_errcode,
- connection->fd);
+ zlog_debug("%s [Event] BGP error %d on fd %d", peer->host,
+ connection->connection_errcode, connection->fd);
/* Closed connection or error on the socket */
if (peer_established(connection)) {
- if ((CHECK_FLAG(peer->flags, PEER_FLAG_GRACEFUL_RESTART)
- || CHECK_FLAG(peer->flags,
- PEER_FLAG_GRACEFUL_RESTART_HELPER))
- && CHECK_FLAG(peer->sflags, PEER_STATUS_NSF_MODE)) {
+ if ((CHECK_FLAG(peer->flags, PEER_FLAG_GRACEFUL_RESTART) ||
+ CHECK_FLAG(peer->flags, PEER_FLAG_GRACEFUL_RESTART_HELPER)) &&
+ CHECK_FLAG(peer->sflags, PEER_STATUS_NSF_MODE)) {
peer->last_reset = PEER_DOWN_NSF_CLOSE_SESSION;
SET_FLAG(peer->sflags, PEER_STATUS_NSF_WAIT);
} else
@@ -9202,29 +9193,25 @@ static void bgp_process_conn_error(struct event *event)
bgp_clearing_batch_end(bgp);
if (bgp_debug_neighbor_events(NULL))
- zlog_debug("%s: dequeued and processed %d peers", __func__,
- counter);
+ zlog_debug("%s: dequeued and processed %d peers", __func__, counter);
}
/*
* Enqueue a connection with an error to be handled in the main pthread;
* this is called from the io pthread.
*/
-int bgp_enqueue_conn_err(struct bgp *bgp, struct peer_connection *connection,
- int errcode)
+int bgp_enqueue_conn_err(struct bgp *bgp, struct peer_connection *connection, int errcode)
{
frr_with_mutex (&bgp->peer_errs_mtx) {
connection->connection_errcode = errcode;
/* Careful not to double-enqueue */
if (!bgp_peer_conn_errlist_anywhere(connection)) {
- bgp_peer_conn_errlist_add_tail(&bgp->peer_conn_errlist,
- connection);
+ bgp_peer_conn_errlist_add_tail(&bgp->peer_conn_errlist, connection);
}
}
/* Ensure an event is scheduled */
- event_add_event(bm->master, bgp_process_conn_error, bgp, 0,
- &bgp->t_conn_errors);
+ event_add_event(bm->master, bgp_process_conn_error, bgp, 0, &bgp->t_conn_errors);
return 0;
}
@@ -9240,8 +9227,7 @@ struct peer_connection *bgp_dequeue_conn_err(struct bgp *bgp, bool *more_p)
frr_with_mutex (&bgp->peer_errs_mtx) {
connection = bgp_peer_conn_errlist_pop(&bgp->peer_conn_errlist);
- if (bgp_peer_conn_errlist_const_first(
- &bgp->peer_conn_errlist) != NULL)
+ if (bgp_peer_conn_errlist_const_first(&bgp->peer_conn_errlist) != NULL)
more = true;
}
@@ -9257,8 +9243,7 @@ struct peer_connection *bgp_dequeue_conn_err(struct bgp *bgp, bool *more_p)
*/
void bgp_conn_err_reschedule(struct bgp *bgp)
{
- event_add_event(bm->master, bgp_process_conn_error, bgp, 0,
- &bgp->t_conn_errors);
+ event_add_event(bm->master, bgp_process_conn_error, bgp, 0, &bgp->t_conn_errors);
}
printfrr_ext_autoreg_p("BP", printfrr_bp);
diff --git a/bgpd/bgpd.h b/bgpd/bgpd.h
index e7ddd7225..afce11b91 100644
--- a/bgpd/bgpd.h
+++ b/bgpd/bgpd.h
@@ -422,7 +422,7 @@ struct bgp_clearing_info {
};
/* Batch is open, new peers can be added */
-#define BGP_CLEARING_INFO_FLAG_OPEN (1 << 0)
+#define BGP_CLEARING_INFO_FLAG_OPEN (1 << 0)
/* BGP instance structure. */
struct bgp {
@@ -2628,8 +2628,7 @@ int bgp_global_gr_init(struct bgp *bgp);
int bgp_peer_gr_init(struct peer *peer);
/* APIs for the per-bgp peer connection error list */
-int bgp_enqueue_conn_err(struct bgp *bgp, struct peer_connection *connection,
- int errcode);
+int bgp_enqueue_conn_err(struct bgp *bgp, struct peer_connection *connection, int errcode);
struct peer_connection *bgp_dequeue_conn_err(struct bgp *bgp, bool *more_p);
void bgp_conn_err_reschedule(struct bgp *bgp);
@@ -2965,11 +2964,9 @@ extern void bgp_session_reset_safe(struct peer *peer, struct listnode **nnode);
*/
bool bgp_clearing_batch_add_peer(struct bgp *bgp, struct peer *peer);
/* Add a prefix/dest to a clearing batch */
-void bgp_clearing_batch_add_dest(struct bgp_clearing_info *cinfo,
- struct bgp_dest *dest);
+void bgp_clearing_batch_add_dest(struct bgp_clearing_info *cinfo, struct bgp_dest *dest);
/* Check whether a dest's peer is relevant to a clearing batch */
-bool bgp_clearing_batch_check_peer(struct bgp_clearing_info *cinfo,
- const struct peer *peer);
+bool bgp_clearing_batch_check_peer(struct bgp_clearing_info *cinfo, const struct peer *peer);
/* Check whether a clearing batch has any dests to process */
bool bgp_clearing_batch_dests_present(struct bgp_clearing_info *cinfo);
/* Returns the next dest for batch clear processing */
To apply the style suggestions:
curl https://gist.githubusercontent.com/polychaeta/01efac4fb1f8111d13be09febd2689aa/raw/8cde1eca9038df4b14328d09ad61eb27410fefbb/style.diff | git apply -
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Loading