-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd: fix use single whitespace when displaying flowspec entries #17510
Merged
riw777
merged 1 commit into
FRRouting:master
from
pguibert6WIND:show_bgp_flowspec_extra_space
Nov 26, 2024
Merged
bgpd: fix use single whitespace when displaying flowspec entries #17510
riw777
merged 1 commit into
FRRouting:master
from
pguibert6WIND:show_bgp_flowspec_extra_space
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an extra space in the 'Displayed' line of show bgp command, that should not be present. Fix this by being consistent with the output of the other address families. Fixes: ("a1baf9e84f71") bgpd: Use single whitespace when displaying show bgp summary Signed-off-by: Philippe Guibert <[email protected]>
ton31337
approved these changes
Nov 26, 2024
@Mergifyio backport stable/10.2 stable/10.1 stable/10.0 |
Can we fix frrbot? |
✅ Backports have been created
|
riw777
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
This was referenced Nov 26, 2024
ton31337
added a commit
that referenced
this pull request
Nov 28, 2024
bgpd: fix use single whitespace when displaying flowspec entries (backport #17510)
ton31337
added a commit
that referenced
this pull request
Nov 28, 2024
bgpd: fix use single whitespace when displaying flowspec entries (backport #17510)
ton31337
added a commit
that referenced
this pull request
Nov 28, 2024
bgpd: fix use single whitespace when displaying flowspec entries (backport #17510)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an extra space in the 'Displayed' line of show bgp command, that should not be present.
Fix this by being consistent with the output of the other address families.
Fixes: ("a1baf9e84f71") bgpd: Use single whitespace when displaying show bgp summary