build: improve readability of Makefile.am & the respective subdir.am
#17516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello; any news on the PR? |
|
@eqvinox can you take a look at this? These changes are in relation to some bitcode compilation work done by @eqvinox several years back. In all honesty the only person who understands this bit of code is them. Let's see if we can get a review. I just completely removed the SUFFIXES and the rules and everything built properly for me. So I have no idea what is even needed here at all. |
|
Thanks for having taken a look, @donaldsharp; indeed, these extensions do appear only once in the repo. They were introduced for LLVM IR compilation (8fb4037). # git grep -P '\.l?o\.bc'
Makefile.am:SUFFIXES += .lo.bc .o.bc
Makefile.am:.o.o.bc:
Makefile.am:.lo.lo.bc:@eqvinox, does the change make sense? Let me know, I will push subsequent PRs. I spotted other places wherein SUFFIXES could be removed: the rules could be more legible. # git grep -n SUFFIXES
Makefile.am:132:SUFFIXES =
Makefile.am:159:SUFFIXES += .proto .pb-c.c .pb-c.h
Makefile.am:307:SUFFIXES += .lo.bc .o.bc
babeld/Makefile:10:.SUFFIXES:
bfdd/Makefile:10:.SUFFIXES:
bgpd/Makefile:10:.SUFFIXES:
bgpd/rfp-example/librfp/Makefile:10:.SUFFIXES:
bgpd/rfp-example/rfptest/Makefile:10:.SUFFIXES:
doc/Makefile:18:.SUFFIXES:
doc/developer/Makefile:16:.SUFFIXES:
doc/manpages/Makefile:12:.SUFFIXES:
doc/user/Makefile:16:.SUFFIXES:
eigrpd/Makefile:10:.SUFFIXES:
fpm/Makefile:10:.SUFFIXES:
grpc/Makefile:10:.SUFFIXES:
grpc/subdir.am:33:SUFFIXES += .pb.h .pb.cc .grpc.pb.cc
isisd/Makefile:10:.SUFFIXES:
ldpd/Makefile:10:.SUFFIXES:
lib/Makefile:10:.SUFFIXES:
lib/subdir.am:490:SUFFIXES += _clippy.c
lib/subdir.am:503:SUFFIXES += .xref
mgmtd/Makefile:10:.SUFFIXES:
nhrpd/Makefile:10:.SUFFIXES:
ospf6d/Makefile:10:.SUFFIXES:
ospfclient/Makefile:10:.SUFFIXES:
ospfd/Makefile:10:.SUFFIXES:
pathd/Makefile:10:.SUFFIXES:
pbrd/Makefile:10:.SUFFIXES:
pimd/Makefile:10:.SUFFIXES:
qpb/Makefile:10:.SUFFIXES:
ripd/Makefile:10:.SUFFIXES:
ripngd/Makefile:10:.SUFFIXES:
sharpd/Makefile:10:.SUFFIXES:
staticd/Makefile:10:.SUFFIXES:
tests/Makefile:10:.SUFFIXES:
tools/Makefile:10:.SUFFIXES:
vrrpd/Makefile:10:.SUFFIXES:
vtysh/Makefile:10:.SUFFIXES:
watchfrr/Makefile:10:.SUFFIXES:
yang/subdir.am:1:SUFFIXES += .yang .yang.c .yin .yin.c
zebra/Makefile:10:.SUFFIXES:
# git grep -Pn '^\.[a-z_]+([a-z\._])+:'
Makefile.am:309:.o.o.bc:
Makefile.am:311:.lo.lo.bc:
grpc/subdir.am:42:.proto.pb.cc:
grpc/subdir.am:44:.proto.grpc.pb.cc:
lib/subdir.am:491:.c_clippy.c:
lib/subdir.am:543:.l.c:
lib/subdir.am:545:.y.c:
yang/subdir.am:4:.yang.yang.c:
yang/subdir.am:6:.yin.yin.c: |
ariel-anieli
force-pushed
the
makefile
branch
from
ff6203e to
ca754c3
Compare
|
The push force was a rebase. |
* replaced suffix rules by pattern rules * such pattern rules are already used in Makefile.am * so doing, the suffixes `.lo.bc` & `.o.bc` are no more needed in SUFFIXES * remove needless macro SUFFIXES; meant for a suffix rule; no more needed * replaced by a pattern rule in 9b8f605. Link: https://www.gnu.org/software/make/manual/html_node/Suffix-Rules.html Link: https://www.gnu.org/s/make/manual/html_node/Pattern-Rules.html Fixes: 9b8f605 ("build: clean up mgmtd lib protobuf make syntax") Signed-off-by: Ariel Otilibili <[email protected]>
* replaced suffix rules by pattern rules * such pattern rules are already used in Makefile.am * so doing, the suffixes `.lo.bc` & `.o.bc` are no more needed in SUFFIXES. Link: https://www.gnu.org/software/make/manual/html_node/Suffix-Rules.html Link: https://www.gnu.org/s/make/manual/html_node/Pattern-Rules.html Signed-off-by: Ariel Otilibili <[email protected]>
* replaced suffix rule by pattern rule * same pattern than in 9b8f605 * so doing, SUFFIXES are no more needed. Link: https://www.gnu.org/software/make/manual/html_node/Suffix-Rules.html Link: https://www.gnu.org/software/make/manual/html_node/Pattern-Rules.html Signed-off-by: Ariel Otilibili <[email protected]>
* replaced suffix rules by pattern rules * `.pb.h`, `.pb.cc`, & `.grpc.pb.cc` are no more needed in SUFFIXES. Link: https://www.gnu.org/software/make/manual/html_node/Suffix-Rules.html Link: https://www.gnu.org/s/make/manual/html_node/Pattern-Rules.html Signed-off-by: Ariel Otilibili <[email protected]>
ariel-anieli
force-pushed
the
makefile
branch
from
ca754c3 to
8ab56a1
Compare
ariel-anieli
changed the title
Makefile.amMakefile.am & subdir.am
ariel-anieli
changed the title
Makefile.am & subdir.amMakefile.am & the respective subdir.am
ariel-anieli
changed the title
Makefile.am & the respective subdir.amMakefile.am & the respective subdir.am
The push force was a rebase, and the inclusion of the changes I spoke about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Hello committers,
Thanks for maintaining the project; this is my first (up to date) contribution. I would like to understand how are implemented routing protocols.
This PR improves the readability of
Makefile.am.Thank you,
How?
Makefile.amSUFFIXES.