Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove no-op "netns NAMESPACE" command from the docs #17538

Merged
merged 2 commits into from
Dec 7, 2024
Merged

doc: remove no-op "netns NAMESPACE" command from the docs #17538

merged 2 commits into from
Dec 7, 2024

Conversation

idryzhov
Copy link
Contributor

No description provided.

@frrbot frrbot bot added the documentation label Nov 30, 2024
ton31337
ton31337 reviewed Dec 1, 2024
View reviewed changes
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add a deprecation (CONFDATE) for this command too?

pguibert6WIND
pguibert6WIND approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@pguibert6WIND pguibert6WIND left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

riw777
riw777 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ... waiting to see if @ton31337 's comment will be addressed before merging

@frrbot frrbot bot added the zebra label Dec 7, 2024
@idryzhov
Copy link
Contributor Author

idryzhov commented Dec 7, 2024

Maybe we can add a deprecation (CONFDATE) for this command too?

Done

@github-actions github-actions bot added the rebase PR needs rebase label Dec 7, 2024
@ton31337 ton31337 merged commit 797cf47 into FRRouting:master Dec 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pguibert6WIND pguibert6WIND pguibert6WIND approved these changes

@ton31337 ton31337 ton31337 approved these changes

@riw777 riw777 riw777 approved these changes

Assignees
No one assigned
Labels
documentation master rebase PR needs rebase size/S zebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@idryzhov @riw777 @ton31337 @pguibert6WIND