Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Fix remote-as with peer-group #17542

Merged

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Dec 1, 2024

Closes #17541

Previously AS_UNSPECIFIED was treated as 0, but with now it's 1 after renumbering
peer_asn_type enum.

Fixes: 0dfe256 ("bgpd: Implement neighbor X remote-as auto")

Signed-off-by: Donatas Abraitis <[email protected]>
@c-po
Copy link
Contributor

c-po commented Dec 1, 2024

I can confirm this fixes the issue in question. Please create a backport for stable/10.2

@ton31337
Copy link
Member Author

ton31337 commented Dec 1, 2024

@Mergifyio backport stable/10.2

Copy link

mergify bot commented Dec 1, 2024

backport stable/10.2

✅ Backports have been created

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit e9c9db0 into FRRouting:master Dec 3, 2024
18 checks passed
@ton31337 ton31337 deleted the fix/peer-group_remote_as_regression branch December 3, 2024 15:09
@pguibert6WIND
Copy link
Member

pguibert6WIND commented Dec 20, 2024

https://github.com/Mergifyio backport stable/10.1 stable/10.0

Copy link

mergify bot commented Dec 20, 2024

stable /10.1 stable/10.0

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

Copy link

mergify bot commented Dec 20, 2024

backport stable/10.1 stable/10.0

✅ Backports have been created

@ton31337
Copy link
Member Author

@pguibert6WIND this is not related to 10.1 and below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bgp: defining peer-group for neighbor will remove remote-as setting
4 participants