bgpd: fix peer up message for loc-rib not sent #17545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguibert6WIND
force-pushed
the
peerup_loc_rib_wrong_format
branch
from
4d9fcf5 to
601576f
Compare
pguibert6WIND
changed the title
pguibert6WIND
force-pushed
the
peerup_loc_rib_wrong_format
branch
from
601576f to
829d9a9
Compare
|
hi @pguibert6WIND, please let me know if i'm wrong |
|
ci:rerun |
thanks to confirm this is an issue. |
pguibert6WIND
force-pushed
the
peerup_loc_rib_wrong_format
branch
from
829d9a9 to
5c1e11c
Compare
|
added test to ensure everything is correct. |
|
ci:rerun one more time |
|
looks good thanks |
pguibert6WIND
force-pushed
the
peerup_loc_rib_wrong_format
branch
from
5c1e11c to
1c5fb9e
Compare
At startup, there is no peer up message for loc-rib instance peer. Instead, a global peer up message with address 0.0.0.0 is sent. Such message is wrong, violates the RFC and should be dropped by a strict collector. Actually, the peer type message sent is wrong, and should be set to LOC-RIB peer type. Fix this by changing the peer type of peer up message to either loc-rib or global instance peer type. Fixes: 035304c ("bgpd: bmp loc-rib peer up/down for vrfs") Signed-off-by: Philippe Guibert <[email protected]>
Add a test at startup to ensure that peer up message for loc-rib is correctly set. Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
peerup_loc_rib_wrong_format
branch
from
1c5fb9e to
f921a8d
Compare
|
ci:rerun unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At startup, there is no peer up message for loc-rib instance peer. Instead, a global peer up message with address 0.0.0.0 is sent.
Such message is wrong, violates the RFC and should be dropped by a strict collector. Actually, the peer type message sent is wrong, and should be set to LOC-RIB peer type.
Fix this by changing the peer type of peer up message to either loc-rib or global instance peer type.
Fixes: 035304c ("bgpd: bmp loc-rib peer up/down for vrfs")