Some cleanups #17547
Merged
Some cleanups #17547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not used in bgp_clist.c so let's just remove it. Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
This code should not be outputting anything to the /tmp directory, remove commented out code Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
Use the appropriate log directory. Signed-off-by: Donald Sharp <[email protected]>
Cleanup usage of log file into /tmp. Remove usage of debugs that will slow down test and remove password. Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
mjstapp
reviewed
Dec 2, 2024
| ! debug ospf event | ||
| ! debug ospf client | ||
| ! debug ospf lsa | ||
| ! debug ospf packet all | ||
|
|
||
| hostname r1 | ||
| password zebra | ||
| log file /tmp/r1-frr.log | ||
| ip forwarding |
There was a problem hiding this comment.
in several places this was removed - is it a problem to leave it here?
There was a problem hiding this comment.
no not really. Just didn't catch it. Can I do another PR at a later time that removes the ip forwarding from a bunch of places that is not needed?
mjstapp
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for what is done.