bgpd: CLI Changes #17553
Open
bgpd: CLI Changes #17553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket:#3229030
Testing Done: UT
Added sub group and json support for l2vpn update group.
TEST:
spine-1# show ip bgp l2vpn evpn update-groups json
{
"default":{
"3":{
"groupCreateTime":{
"epoch":1670880656,
"epochString":"Mon Dec 12 21:30:56 2022\n"
},
"afi":"l2vpn",
"safi":"evpn",
"minRouteAdvInt":0,
"subGroup":[
{
"subGroupId":3,
"groupCreateTime":{
"epoch":1670880656,
"epochString":"Mon Dec 12 21:30:56 2022\n"
},
"statistics":{
"joinEvents":6,
"pruneEvents":0,
"mergeEvents":2,
"splitEvents":0,
"switchEvents":0,
"peerRefreshEvents":0,
"mergeCheckEvents":0
},
"coalesceTime":1300,
"version":19,
"packetQueueInfo":{
"qeueueLen":0,
"queuedTotal":466,
"queueHwmLen":39,
"totalEnqueued":466
},
"adjListCount":2071,
"needsRefresh":false,
"peers":[
"swp6",
"swp1",
"swp3",
"swp4",
"swp2",
"swp5"
]
}
]
}
}
}
Signed-off-by: Ashwini Reddy <[email protected]>
Add support for command show bgp l2vpn evpn route rd <rd> prefix <prefix> [json] This is currently a Cumulus-specific change. Multiple of the EVPN operational commands need to be unified with upstream changes which have now caught up to display most of the needed information of the global EVPN table but differ in some aspects from existing Cumulus commands. The unification also needs to handle per-VNI (per-EVI) information and will be post CL 4.2. Signed-off-by: Vivek Venkatraman <[email protected]> Ticket: CM-26918 Reviewed By: Output reviewed by Mahesh & Chirag Testing Done: 1. Manual check 2. Precommit - https://trdb.cumulusnetworks.com/trdb3/product/1/userjobs?user=vivek&job=32
Fixed selectionDeferralTimer JSON field which was displaying stalepath timer value instead of select_defer_time. Issue:3803619 Signed-off-by: Pooja Jagadeesh Doijode <[email protected]>
Signed-off-by: Krishnasamy R <[email protected]>
krishna-samy
force-pushed
the
bgpd-cli-changes
branch
from
acbcc74 to
abdedc5
Compare
ton31337
reviewed
Dec 4, 2024
| /* | ||
| * Display global EVPN routing table for specific RD and prefix (type-5). | ||
| */ | ||
| DEFUN(show_bgp_l2vpn_evpn_route_rd_prefix, |
| "Route Distinguisher\n" | ||
| "ASN:XX or A.B.C.D:XX\n" | ||
| "prefix\n" | ||
| "IP prefix\n" |
| json_object *json = NULL; | ||
|
|
||
| bgp = bgp_get_evpn(); | ||
| if (!bgp) |
There was a problem hiding this comment.
Shouldn't we be consistent and return an empty JSON in such a case also if the user expects a JSON output?
| ret = str2prefix_rd(argv[idx + 1]->arg, &prd); | ||
| if (!ret) { | ||
| vty_out(vty, "%% Malformed Route Distinguisher\n"); | ||
| return CMD_WARNING; |
There was a problem hiding this comment.
Same here, and everywhere else returning a warning. We have already some patterns when handling similar cases, e.g.:
json_object_string_add(
json_no, "warning",
"No such neighbor or address family");| "Detailed info about dynamic update groups\n") | ||
| DEFPY(show_bgp_l2vpn_evpn_updgrps, | ||
| show_bgp_l2vpn_evpn_updgrps_cmd, | ||
| "show [ip] bgp l2vpn evpn update-groups [(1-1000)$subgrpid] [json$json]", |
There was a problem hiding this comment.
Can we add documentation for this command too (since you touch it)?
Also... to me, it sounds like Show EVPN update-groups with an update-group id instead of subgroup-id. I think telling explicitly that we want a subgroup-id would be better (e.g.: show bgp l2vpn evpn update-group [subgroup-id (1-1000)...), no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has below changes