Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: enable test failure detection and fix resulting failures #17647

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

choppsv1
Copy link
Contributor

@choppsv1 choppsv1 commented Dec 14, 2024

  • This tests were not actually failing when the results didn't match. Fail now. Also fix the tests that are now found to be failing incorrectly (wrong expected result).

  • Also add option for multiple yang paths in generate callback tool

@frrbot frrbot bot added bugfix tests Topotests, make check, etc labels Dec 14, 2024
@frrbot frrbot bot added the mgmt FRR Management Infra label Dec 15, 2024
@choppsv1 choppsv1 changed the title tests: enable failure and fix one testcase tests: enable test failure detection and fix resulting failures Dec 16, 2024
@frrbot frrbot bot added the tools label Dec 16, 2024
@github-actions github-actions bot added the rebase PR needs rebase label Dec 23, 2024
This test was not actually failing when the results didn't match. Fail
now. Also fix the tests that are now found to be failing incorrectly
(wrong expected result).

Signed-off-by: Christian Hopps <[email protected]>
@Jafaral Jafaral merged commit 803ff41 into FRRouting:master Dec 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix master mgmt FRR Management Infra rebase PR needs rebase size/XL tests Topotests, make check, etc tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants