Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: remove unnecessary wildcard fields from pim acl test #17840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests: remove unnecessary wildcard fields from pim acl test #17840

wants to merge 1 commit into from
+0 −16

Conversation

Jafaral
Copy link
Member

@Jafaral Jafaral commented Jan 10, 2025

No description provided.

@frrbot frrbot bot added the tests Topotests, make check, etc label Jan 10, 2025
@csiltala
Copy link

sockFd, uptime/upTime, timer, no problem removing those. The source at line 227 is actually *, not a JSON wildcard (without checking, likely the other sources as well), see comment above that section.

# Note: json_cmp treats "*" as wildcard but in this case that's actually what the source is

I wasn't sure if there's a way to explicitly match an * but that would be a good fix here

@Jafaral
Copy link
Member Author

Jafaral commented Jan 10, 2025

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master size/S tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jafaral @csiltala