bgpd: fix bfd with update-source in peer-group #17904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
reviewed
Jan 22, 2025
| @@ -114,6 +114,10 @@ void bgp_peer_config_apply(struct peer *p, struct peer_group *pg) | |||
| */ | |||
| gconfig = pg->conf; | |||
|
|
|||
| if (CHECK_FLAG(gconfig->flags, PEER_FLAG_UPDATE_SOURCE) || | |||
There was a problem hiding this comment.
We should use peergroup_flag_check(), right?
There was a problem hiding this comment.
Not sure to understand peergroup_flag_check() but my previous code (without that function) seems correct.
I want to check for the presence of update-source in the update-group config. If not present in update group, check for the presence of update-source in the peer config.
There was a problem hiding this comment.
My concern was that peergroup_flag_check() actually checks overridden/inverted flags according to peer-group/peer configurations.
louis-6wind
force-pushed
the
fix-bfd-pg-update-group
branch
2 times, most recently
from
87f5daa to
6639c2d
Compare
Check bfd with update-source in peer-group. Signed-off-by: Louis Scalbert <[email protected]>
Fix BFD session not created when the peer is in update-group with the update-source option. Signed-off-by: Louis Scalbert <[email protected]>
louis-6wind
force-pushed
the
fix-bfd-pg-update-group
branch
from
6639c2d to
dee3fd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix BFD session not created when the peer is in update-group with the update-source option.