ospf6d: virtual link support #9293

eqvinox · 2021-08-04T12:09:12Z

WORK IN PROGRESS

Posting this as a draft PR so people are aware of it & we don't waste time if anyone else works on OSPFv3 virtual links.

This passes preliminary testing, but still has a bunch of rough edges. Also, no docs and tests yet. It'll be a bit until those come due to priorities being this way :(

NB: this is based on top of the PtMP draft (#9198) since some of the changes are related.

polychaeta

Thanks for your contribution to FRR!

One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

NetDEF-CI · 2021-08-04T12:10:28Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20793/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Failed

Checkout code: Failed (click for details)

PullReq merge failed. Please rebase your branch:
see merge log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20793/artifact/CHECKOUT/ErrorLog/log_merge.txt

eqvinox · 2021-08-04T13:09:28Z

This is a DRAFT. I'm aware it fails things, has conflicts and formatting issues. It's posted publicly for visiblity and to avoid duplicate work.

LabN-CI · 2021-08-04T13:54:53Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git pull/9293 `e07d897` (merge failed)
Date	08/04/2021
Start	09:29:19
Finish	09:54:49
Run-Time	25:30
Total	1813
Pass	1813
Fail	0
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-08-04-09:29:19.txt
Log	autoscript-2021-08-04-09:30:36.log.bz2
Memory	519 513 430

For details, please contact louberger

idryzhov · 2021-08-04T14:38:34Z

I wonder if there's any possibility to reuse some code from ospfd... It's sad to see all those features be implemented in a slightly different way in two daemons when actually it may be almost the same codebase.

polychaeta

Thanks for your contribution to FRR!

One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one
One of your commits does not have a blank line between the summary and body; this will break git log --oneline
Style checking failed; check logs

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

NetDEF-CI · 2021-08-26T15:06:30Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21405/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Failed

Checkout code: Failed (click for details)

PullReq merge failed. Please rebase your branch:
see merge log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21405/artifact/CHECKOUT/ErrorLog/log_merge.txt

LabN-CI · 2021-08-26T16:18:12Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git pull/9293 `c694a11` (merge failed)
Date	08/26/2021
Start	11:37:05
Finish	12:18:09
Run-Time	41:04
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-08-26-11:37:05.txt
Log	autoscript-2021-08-26-11:38:13.log.bz2
Memory	507 519 430

For details, please contact louberger

polychaeta

Thanks for your contribution to FRR!

One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one
One of your commits does not have a blank line between the summary and body; this will break git log --oneline
Style checking failed; check logs

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

NetDEF-CI · 2021-08-26T16:28:32Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21407/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Failed

Checkout code: Failed (click for details)

PullReq merge failed. Please rebase your branch:
see merge log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21407/artifact/CHECKOUT/ErrorLog/log_merge.txt

LabN-CI · 2021-08-26T17:58:12Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git pull/9293 `2a21d5f` (merge failed)
Date	08/26/2021
Start	13:16:58
Finish	13:58:10
Run-Time	41:12
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-08-26-13:16:58.txt
Log	autoscript-2021-08-26-13:18:21.log.bz2
Memory	512 514 425

For details, please contact louberger

NetDEF-CI · 2021-08-26T19:40:41Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21413/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Failed

Checkout code: Failed (click for details)

PullReq merge failed. Please rebase your branch:
see merge log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21413/artifact/CHECKOUT/ErrorLog/log_merge.txt

NetDEF-CI · 2021-08-26T19:46:23Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21415/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Failed

Checkout code: Failed (click for details)

PullReq merge failed. Please rebase your branch:
see merge log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21415/artifact/CHECKOUT/ErrorLog/log_merge.txt

LabN-CI · 2021-08-26T20:28:31Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git pull/9293 `1892fe2` (merge failed)
Date	08/26/2021
Start	15:47:09
Finish	16:28:28
Run-Time	41:19
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-08-26-15:47:09.txt
Log	autoscript-2021-08-26-15:48:24.log.bz2
Memory	494 492 430

For details, please contact louberger

LabN-CI · 2021-08-27T10:59:34Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/9293 `f9886e1`
Date	08/27/2021
Start	06:33:12
Finish	06:59:32
Run-Time	26:20
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-08-27-06:33:12.txt
Log	autoscript-2021-08-27-06:34:26.log.bz2
Memory	488 487 426

For details, please contact louberger

NetDEF-CI · 2021-08-27T13:32:07Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21425/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for ospf6_interface.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2611: FILE: /tmp/f1-17097/ospf6_interface.c:2611:
Report for ospf6_interface.h | 4 issues
===============================================
< WARNING: function definition argument 'struct interface *' should also have an identifier name
< #219: FILE: /tmp/f1-17097/ospf6_interface.h:219:
< WARNING: function definition argument 'struct ospf6_interface *' should also have an identifier name
< #220: FILE: /tmp/f1-17097/ospf6_interface.h:220:
Report for ospf6_intra.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #349: FILE: /tmp/f1-17097/ospf6_intra.c:349:
< WARNING: line over 80 characters
< #351: FILE: /tmp/f1-17097/ospf6_intra.c:351:
Report for ospf6_message.c | 2 issues
===============================================
< WARNING: Comparisons should place the constant on the right side of the test
< #1807: FILE: /tmp/f1-17097/ospf6_message.c:1807:
Report for ospf6_neighbor.c | 10 issues
===============================================
< WARNING: line over 80 characters
< #290: FILE: /tmp/f1-17097/ospf6_neighbor.c:290:
< WARNING: line over 80 characters
< #293: FILE: /tmp/f1-17097/ospf6_neighbor.c:293:
< WARNING: Missing a blank line after declarations
< #859: FILE: /tmp/f1-17097/ospf6_neighbor.c:859:
< WARNING: space prohibited between function name and open parenthesis '('
< #894: FILE: /tmp/f1-17097/ospf6_neighbor.c:894:
< WARNING: space prohibited between function name and open parenthesis '('
< #1610: FILE: /tmp/f1-17097/ospf6_neighbor.c:1610:
Report for ospf6_vlink.c | 39 issues
===============================================
WARNING: line over 80 characters
#74: FILE: /tmp/f1-17097/ospf6_vlink.c:74:
+DEFINE_MTYPE_STATIC(OSPF6D, OSPF6_VLINK_ADDR,   "OSPF6 virtual link address base");

WARNING: braces {} are not necessary for single statement blocks
#185: FILE: /tmp/f1-17097/ospf6_vlink.c:185:
+	while ((vaddr = ospf6_vlink_addrs_pop(head))) {
+		XFREE(MTYPE_OSPF6_VLINK_ADDR, vaddr);
+	}

WARNING: space prohibited between function name and open parenthesis '('
#313: FILE: /tmp/f1-17097/ospf6_vlink.c:313:
+	frr_each (ospf6_area_vlinks, oa->vlinks, vlink)

WARNING: Missing a blank line after declarations
#488: FILE: /tmp/f1-17097/ospf6_vlink.c:488:
+	uint32_t area;
+	VTY_DECLVAR_CONTEXT(ospf6, o);

WARNING: space prohibited between function name and open parenthesis '('
#553: FILE: /tmp/f1-17097/ospf6_vlink.c:553:
+	frr_each (ospf6_area_vlinks, oa->vlinks, vlink) {

WARNING: line over 80 characters
#557: FILE: /tmp/f1-17097/ospf6_vlink.c:557:
+			vty_out(vty, " hello-interval %u", vlink->hello_interval);

WARNING: line over 80 characters
#560: FILE: /tmp/f1-17097/ospf6_vlink.c:560:
+		if (vlink->retransmit_interval != VLINK_DEFAULT_RETRANSMIT_INTERVAL)

WARNING: line over 80 characters
#561: FILE: /tmp/f1-17097/ospf6_vlink.c:561:
+			vty_out(vty, " retransmit-interval %u", vlink->retransmit_interval);

WARNING: line over 80 characters
#563: FILE: /tmp/f1-17097/ospf6_vlink.c:563:
+			vty_out(vty, " transmit-delay %u", vlink->transmit_delay);

CLANG Static Analyzer Summary

Github Pull Request 9293, comparing to Git base SHA 3e386e9
Base image data for Git 3e386e9 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21425/artifact/shared/static_analysis/index.html

LabN-CI · 2021-10-22T17:23:33Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git pull/9293 `f9886e1` (merge failed)
Date	10/22/2021
Start	12:57:15
Finish	13:23:30
Run-Time	26:15
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-10-22-12:57:15.txt
Log	autoscript-2021-10-22-12:58:29.log.bz2
Memory	516 508 425

For details, please contact louberger

LabN-CI · 2021-10-22T17:50:23Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git pull/9293 `f9886e1` (merge failed)
Date	10/22/2021
Start	13:23:45
Finish	13:50:20
Run-Time	26:35
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-10-22-13:23:45.txt
Log	autoscript-2021-10-22-13:25:04.log.bz2
Memory	495 488 421

For details, please contact louberger

idryzhov · 2021-10-25T11:12:10Z

ospf6d/ospf6_vlink.c

+	 * on this interface (which would just wreak havoc.)  With an empty
+	 * interface name, the CLI can't invoke "interface XYZ" commands.
+	 */
+	ifp = if_create_name("", o->vrf_id);


FYI: if_create_name is not a public function anymore, you should use if_get_by_name instead.

And also a note regarding the empty interface name. The interface name space is global for VRF-lite backend, so having this single name for all OSPF6 instances is not a robust solution. It works now because of the way we store interfaces in the lib, but I don't think we should rely on that. I think it's better to use something like ospf6-vlink-vrf-name to ensure that the we have unique interface name in each VRF, and add a check on NB validation stage to forbid configuration of interfaces with names starting with ospf6-vlink.

github-actions · 2022-10-13T13:24:33Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

This function is not implemented anywhere. Not sure it ever existed. Signed-off-by: David Lamparter <[email protected]>

Both for virtual links and correct PtMP operation, advertising local addresses as Intra-Prefix with LA set is a prerequisite. Add the appropriate entries. Signed-off-by: David Lamparter <[email protected]>

For PtMP the cost may need to be recalculated when the LL addr changes (since neighbors are configured by LL addr and a different entry with a different cost may match.) Signed-off-by: David Lamparter <[email protected]>

Add a list of configured neighbors for each interface. Only stores cost (and "existence") for now. Signed-off-by: David Lamparter <[email protected]>

This adds a knob to refuse forming adjacencies with neighbors not listed in the config. Only works on PtP/PtMP of course, otherwise the DR/BDR machinery gets broken. Signed-off-by: David Lamparter <[email protected]>

With the configured neighbor list, unicast hellos can be sent. Allow disabling multicast hellos for that scenario. Signed-off-by: David Lamparter <[email protected]>

Some lower layers still don't handle multicast correctly (or efficiently.) Add option to send unicast hellos on explicitly configured neighbors for PtP/PtMP. Signed-off-by: David Lamparter <[email protected]>

This adds the PtMP interface type, which is effectively identical to PtP except that all the database flooding & updates are unicast. Signed-off-by: David Lamparter <[email protected]>

To announce connected prefixes, or not to announce connected prefixes, that is the question... Signed-off-by: David Lamparter <[email protected]>

Update & add docs for all the stuff in the previous 10-ish commits. Signed-off-by: David Lamparter <[email protected]>

The RB-tree of interfaces only contains interfaces that have a non-empty name. Don't try to remove an interface whose name is empty and which was therefore never added to the tree. Signed-off-by: David Lamparter <[email protected]>

To support virtual links, it makes sense to put a dummy interface into the backbone area, which virtual links are neighbors on. That interface shouldn't ever have its various LSDBs used for anything, so the "basic" create/delete added here doesn't create them.

The dummy interface for virtual link support has an empty interface name ("", not null pointer), which can be confusing when printed. Create an `ospf6_ifname()` helper for JSON output and a `%pOI` printfrr modifier for logging/CLI. (Latter also shortens some code a bit.)

Need to access this to find a LA for virtual links if there is none otherwise, so split the filtering into its own function. Also gets rid of a bunch of weird one-use macros while at it.

A connected prefix with a /128 prefix length is... *drumroll* ... a local address. Flag it as such so it can be used for virtual links.

Need to insert virtual link handling inbetween this, so make the second half its own independent function.

Passed preliminary testing, but still somewhat experimental.

NetDEF-CI · 2023-02-11T01:40:59Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9630/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-9630/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9630/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-9630/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9630/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9630/artifact/TOPO9U18I386/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9630/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-9630/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9630/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt

Successful on other platforms/tests

Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 8
Static analyzer (clang)
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 6
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 4
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 5
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 7
Debian 10 deb pkg check
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 arm8 part 4
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 2
Fedora 29 rpm pkg check
Addresssanitizer topotests part 9
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-9630/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9630/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-9630/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9630/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9630/artifact/TOPO9U18I386/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9630/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-9630/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9630/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt

Report for ospf6_interface.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2664: FILE: /tmp/f1-2579406/ospf6_interface.c:2664:
Report for ospf6_interface.h | 2 issues
===============================================
< WARNING: function definition argument 'struct interface *' should also have an identifier name
< #240: FILE: /tmp/f1-2579406/ospf6_interface.h:240:
Report for ospf6_intra.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #352: FILE: /tmp/f1-2579406/ospf6_intra.c:352:
< WARNING: line over 80 characters
< #354: FILE: /tmp/f1-2579406/ospf6_intra.c:354:
Report for ospf6_message.c | 2 issues
===============================================
< WARNING: Comparisons should place the constant on the right side of the test
< #1871: FILE: /tmp/f1-2579406/ospf6_message.c:1871:
Report for ospf6_neighbor.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #327: FILE: /tmp/f1-2579406/ospf6_neighbor.c:327:
< WARNING: line over 80 characters
< #330: FILE: /tmp/f1-2579406/ospf6_neighbor.c:330:
< WARNING: Missing a blank line after declarations
< #840: FILE: /tmp/f1-2579406/ospf6_neighbor.c:840:
Report for ospf6_vlink.c | 31 issues
===============================================
WARNING: line over 80 characters
#74: FILE: /tmp/f1-2579406/ospf6_vlink.c:74:
+DEFINE_MTYPE_STATIC(OSPF6D, OSPF6_VLINK_ADDR,   "OSPF6 virtual link address base");

WARNING: braces {} are not necessary for single statement blocks
#185: FILE: /tmp/f1-2579406/ospf6_vlink.c:185:
+	while ((vaddr = ospf6_vlink_addrs_pop(head))) {
+		XFREE(MTYPE_OSPF6_VLINK_ADDR, vaddr);
+	}

WARNING: Missing a blank line after declarations
#487: FILE: /tmp/f1-2579406/ospf6_vlink.c:487:
+	uint32_t area;
+	VTY_DECLVAR_CONTEXT(ospf6, o);

WARNING: line over 80 characters
#556: FILE: /tmp/f1-2579406/ospf6_vlink.c:556:
+			vty_out(vty, " hello-interval %u", vlink->hello_interval);

WARNING: line over 80 characters
#559: FILE: /tmp/f1-2579406/ospf6_vlink.c:559:
+		if (vlink->retransmit_interval != VLINK_DEFAULT_RETRANSMIT_INTERVAL)

WARNING: line over 80 characters
#560: FILE: /tmp/f1-2579406/ospf6_vlink.c:560:
+			vty_out(vty, " retransmit-interval %u", vlink->retransmit_interval);

WARNING: line over 80 characters
#562: FILE: /tmp/f1-2579406/ospf6_vlink.c:562:
+			vty_out(vty, " transmit-delay %u", vlink->transmit_delay);

CLANG Static Analyzer Summary

Github Pull Request 9293, comparing to Git base SHA 7809df2
Base image data for Git 7809df2 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-PULLREQ2-9630/artifact/shared/static_analysis/index.html

github-actions · 2023-03-17T11:57:29Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

polychaeta added bugfix documentation libfrr ospfv3 labels Aug 4, 2021

polychaeta requested changes Aug 4, 2021

View reviewed changes

polychaeta requested changes Aug 26, 2021

View reviewed changes

eqvinox force-pushed the ospfv3-vlink branch from 1892fe2 to f9886e1 Compare August 27, 2021 09:53

idryzhov reviewed Oct 25, 2021

View reviewed changes

eqvinox mentioned this pull request Jul 5, 2022

ipv6 virtual link feature #11504

Closed

github-actions bot added the conflicts label Oct 13, 2022

eqvinox added 3 commits February 10, 2023 16:40

lib: remove unused connected_add prototype

ab7980c

This function is not implemented anywhere. Not sure it ever existed. Signed-off-by: David Lamparter <[email protected]>

ospf6d: advertise local addresses with LA bit

866bb23

Both for virtual links and correct PtMP operation, advertising local addresses as Intra-Prefix with LA set is a prerequisite. Add the appropriate entries. Signed-off-by: David Lamparter <[email protected]>

ospf6d: factor out link-local addr change

708a603

For PtMP the cost may need to be recalculated when the LL addr changes (since neighbors are configured by LL addr and a different entry with a different cost may match.) Signed-off-by: David Lamparter <[email protected]>

eqvinox added 15 commits February 10, 2023 16:41

ospf6d: allow configuring PtP neighbors & cost

4ab2de8

Add a list of configured neighbors for each interface. Only stores cost (and "existence") for now. Signed-off-by: David Lamparter <[email protected]>

ospf6d: option to restrict PtP neighbor list

9dd56e7

This adds a knob to refuse forming adjacencies with neighbors not listed in the config. Only works on PtP/PtMP of course, otherwise the DR/BDR machinery gets broken. Signed-off-by: David Lamparter <[email protected]>

ospf6d: option to disable multicast hellos

0565a2a

With the configured neighbor list, unicast hellos can be sent. Allow disabling multicast hellos for that scenario. Signed-off-by: David Lamparter <[email protected]>

ospf6d: support unicast hellos on PtP/PtMP

86a1004

Some lower layers still don't handle multicast correctly (or efficiently.) Add option to send unicast hellos on explicitly configured neighbors for PtP/PtMP. Signed-off-by: David Lamparter <[email protected]>

ospf6d: add point-to-multipoint interface mode

49bef9a

This adds the PtMP interface type, which is effectively identical to PtP except that all the database flooding & updates are unicast. Signed-off-by: David Lamparter <[email protected]>

ospf6d: connected prefix toggle for PtP/PtMP

636b720

To announce connected prefixes, or not to announce connected prefixes, that is the question... Signed-off-by: David Lamparter <[email protected]>

doc: update user docs for OSPFv3 PtMP changes

af9ddb7

Update & add docs for all the stuff in the previous 10-ish commits. Signed-off-by: David Lamparter <[email protected]>

lib: don't delete item that wasn't added

bb4d774

The RB-tree of interfaces only contains interfaces that have a non-empty name. Don't try to remove an interface whose name is empty and which was therefore never added to the tree. Signed-off-by: David Lamparter <[email protected]>

lib: add if_create_virtual()

553a771

ospf6d: factor out interface address filter

f7d10d1

Need to access this to find a LA for virtual links if there is none otherwise, so split the filtering into its own function. Also gets rid of a bunch of weird one-use macros while at it.

ospf6d: /128 addresses are always local

47cdb2a

A connected prefix with a /128 prefix length is... *drumroll* ... a local address. Flag it as such so it can be used for virtual links.

ospf6d: chop RX function in two

0eeb40f

Need to insert virtual link handling inbetween this, so make the second half its own independent function.

ospf6d: virtual link support

45c4422

Passed preliminary testing, but still somewhat experimental.

eqvinox force-pushed the ospfv3-vlink branch from f9886e1 to 45c4422 Compare February 10, 2023 23:17

github-actions bot added size/XXL and removed conflicts labels Feb 10, 2023

github-actions bot added the conflicts label Mar 17, 2023

ospf6d: virtual link support #9293

Are you sure you want to change the base?

ospf6d: virtual link support #9293

Conversation

eqvinox commented Aug 4, 2021

polychaeta left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Aug 4, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Failed

eqvinox commented Aug 4, 2021

LabN-CI commented Aug 4, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

idryzhov commented Aug 4, 2021

polychaeta left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Aug 26, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Failed

LabN-CI commented Aug 26, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

polychaeta left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Aug 26, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Failed

LabN-CI commented Aug 26, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Aug 26, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Failed

NetDEF-CI commented Aug 26, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Failed

LabN-CI commented Aug 26, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Aug 27, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Aug 27, 2021 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

1 Static Analyzer issues remaining.

LabN-CI commented Oct 22, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Oct 22, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

idryzhov Oct 25, 2021

Choose a reason for hiding this comment

github-actions bot commented Oct 13, 2022

NetDEF-CI commented Feb 11, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

CLANG Static Analyzer Summary

1 Static Analyzer issues remaining.

github-actions bot commented Mar 17, 2023

NetDEF-CI commented Aug 4, 2021 •

edited

Loading

LabN-CI commented Aug 4, 2021 •

edited

Loading

NetDEF-CI commented Aug 26, 2021 •

edited

Loading

LabN-CI commented Aug 26, 2021 •

edited

Loading

NetDEF-CI commented Aug 26, 2021 •

edited

Loading

LabN-CI commented Aug 26, 2021 •

edited

Loading

NetDEF-CI commented Aug 26, 2021 •

edited

Loading

NetDEF-CI commented Aug 26, 2021 •

edited

Loading

LabN-CI commented Aug 26, 2021 •

edited

Loading

LabN-CI commented Aug 27, 2021 •

edited

Loading

NetDEF-CI commented Aug 27, 2021 •

edited

Loading

LabN-CI commented Oct 22, 2021 •

edited

Loading

LabN-CI commented Oct 22, 2021 •

edited

Loading