Upgrade F* to use Z3 4.13.3 #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtzguido
force-pushed
the
nik_z3_4.13.3
branch
from
04b4277 to
a462b9a
Compare
|
I can confirm that F* now successfully builds on aarch64! |
|
NixOS/nixpkgs#327052 just landed and should make this easier. I am considering dropping the old Z3 versions from nixpkgs because they are starting to require a bunch of patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explicitly sets --z3version 4.13.3 for all F* invocations in this repo.
Rather than changing FStarC.Options to flip the default Z3 version, I preferred to set this in all our makefiles, scripts, config files etc., so that we don't break other projects. We can consider flipping the default later.
I also adjusted rlimits and proofs in a couple of places so that they work with 4.13.3
The main difficult one with X64.Vale.Decls, which is fragile: I wrestled with this for a while, but it works now with a large rlimit and a few retries. We have a thread investigating this further with Nikolaj Bjorner, but I don't think that should block us here.
Fixes #3476. Fixes #2828. Fixes #2332. Fixes #2431.
See also #2974 and #2995.