User-friendly error messages #417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranhai613
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move HS version check from InitializeResources to PreInitializeResources
Currently, HS version parsing and lua parsing are done in the same function
InitializeResources. Depending on the order of rapidxml node, sometimes lua parsing is done before HS version parsing. Here is one problem. When you use outdated HS, a bunch of lua errors would occur as well as HS worng version error. If a lot of lua errors occur first, user can easily miss the HS version error that appears at the end of errors they get. Then user would be confused being unaware what is the cause.This pr moves HS version parsing from
InitializeResourcestoPreInitializeResourcesso that it can make sure version parsing is always done before lua parsing. Therefore user will see HS version error first and will be able to come up with the idea that a bunch of lua errors they got later are due to outdated HS version.Add direction about downgrading FTL to function-address-not-found error
People often get error that says "Failed to find address for function AchievementTracker::GetShipAchievements" because they forgot to downgrade FTL.
This pr adds a direction about downgrading FTL when getting address-not-found error for AchievementTracker.
