-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use different ThemeConfig
for each locale
#100
Conversation
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The preview doesn't currently work for other languages because their files still use absolute links. Update: it fixes the top bar, but not the pages |
I asked for help over at Vitepress, and they told me that we were doing it wrong. I have fixed it now, but there is some refactoring I would like to do. I do not have time for that right now, I'll see when I can do it. I also don't know what I should do with the |
ThemeConfig
for each locale
Some people on Crowdin have started using absolute language links to fix the problem on their end. Again, should I modify their files here on GitHub? Can I touch fabric-docs/translated/ru_ru/index.md Line 26 in 39cad1f
(PS: I do not speak Russian) |
We really need to find a way to convey the contributing guidelines to users on Crowdin, as there's no way to do this other than make the contributor process invite-only. |
I dont think this implementation will work with versioning, please test it out if you can. |
Does this mean that we need to stop using absolute links now? |
You should have always been using relative links in translations. |
It didn't. |
Will publish a version for you now. |
0.11.0 is out, update when you can 👍 |
Actually i'll do it now when adding support for nav translations |
- `loadLocales()` now returns `root` as well - Extract `readTranslations()`, `applySidebarTranslations()` - `'Edit this page on GitHub'` is now localised
I think we should merge this without the localisation of the version switcher for now, it can come at a later date. |
LGTM @modmuss50 |
- Refactor `localDir` to `localeDir`
Fix #95
Generate a
ThemeConfig
for each localeMove
CONTRIBUTING.md
tocontributing.md
to avoid rewritingUse relative links for
contributing
filesMove
CONTRIBUTING
files intranslated/**/
Refactor some code
Check if types are correct
Does it work with versioning?Wait forvitepress-versioning-plugin
release