Too many updates #270

its-miroma · 2025-01-22T21:17:48Z

Tip

This diff page may have better performance than the review: main...its-miroma:fmc:framework

Update .github/CODEOWNERS
Update .github/workflows:
- build.yml:
  - run on main only, otherwise pull requests from l10n/main run build twice
  - add conditions to avoid "Run failed" mails
- markdownlint.yml:
  - remove branches, as paths already excludes pull requests from l10n/main
  - remove workflow_dispatch
- publish.yml:
  - run on ubuntu-24.04
  - add conditions to avoid "Run failed" mails
settings.gradle: build latest only
- update.ts: don't add new versions to settings.gradle
Add an h1 heading from $frontmatter.title automatically
- remove all # headings
- .markdownlint-cli2.yaml: enable MD025
add new markdownlint rules:
- max-one-sentence-per-line (not in here)
- incorrect-mod-id
- no-horizontal-rules
- no-html-line-breaks
- `no-trailing-punctuation-in-lists
enable lazy image loading
add a footer
format many files with prettier
add more vscode extension recommendations
hide files that shouldn't be edited in vscode
fix missing codeblock in Block States #272
fix formatting mistakes in translated
lint all markdown files
delete contributing.md under versions

netlify · 2025-01-22T21:18:03Z

✅ Deploy Preview for nimble-elf-d9d491 ready!

Name	Link
🔨 Latest commit	`4fc916d`
🔍 Latest deploy log	https://app.netlify.com/sites/nimble-elf-d9d491/deploys/67a3131fb45dcf000892b0e8
😎 Deploy Preview	https://deploy-preview-270--nimble-elf-d9d491.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

.github/workflows/build.yml

.github/workflows/publish.yml

- Update `.github/CODEOWNERS` - `build.yml`: run on `main` only - otherwise pull requests from `l10n/main` run build twice - `markdownlint.yml`: remove `branches` - `paths` already excludes pull requests from `l10n/main` - `settings.gradle`: build `latest` only - `update.ts`: don't add new versions to `settings.gradle`

- `incorrect-mod-id` - `no-horizontal-rules` - `no-html-line-breaks` - `no-trailing-punctuation-in-lists` - TODO: `max-one-sentence-per-line` --- - don't lint `versions` at all

its-miroma

this is a contender for the most unreviewable PR in the history of GitHub...

its-miroma · 2025-02-03T01:47:04Z

.markdownlint-cli2.yaml

      - name: no-trailing-whitespace
        message: "Don't use trailing whitespace"
        searchPattern: "/ +$/gm"
        replace: ""
        searchScope: code
 customRules:
+  # TODO: add      markdownlint-rule-max-one-sentence-per-line/rule.js


this would be helpful for a few reasons:

no longer worrying about line wraps

longer/complicated sentences stick out

crowdin doesn't show a confusing new line in the middle of source strings

it would however lead to a monstrous diff, so i avoided doing it here.

if i ever wanted to add it, the best way would be to render the markdown files after the sentences split and run a diff on the built files to check for broken/changed formatting

its-miroma · 2025-02-03T01:47:33Z

.vitepress/config.mts

+      image: {
+        lazyLoading: true,
+      },


would appreciate feedback/testing on this

its-miroma · 2025-02-03T01:48:27Z

.vitepress/i18n.ts

+    footer: {
+      copyright: websiteResolver("footer.copyright").replace(
+        "%s",
+        `<a href=\"https://github.com/FabricMC/fabric-docs/blob/main/LICENSE\" target=\"_blank\" rel=\"noreferrer\">${websiteResolver("footer.license")}</a>`


unsure what the best way to sanitize footer.license is

a malicious translation could close the </a>...

its-miroma · 2025-02-03T01:50:42Z

.vitepress/theme/index.ts

+        frontmatter.value.title
+          ? h("h1", { class: "vp-doc" }, frontmatter.value.title)
+          : null,


is there ever a need for two different titles in <head> and <body>?

Yes, the homepage

doc-before (line 35) only includes doc pages, not the homepage nor the 404 page

its-miroma · 2025-02-03T01:51:25Z

.vitepress/theme/style.css

@@ -8,7 +8,7 @@
  font-family: "Flag Emoji Polyfill";
  unicode-range: U+1F1E6-1F1FF, U+1F3F4, U+E0062-E0063, U+E0065, U+E0067,
    U+E006C, U+E006E, U+E0073-E0074, U+E0077, U+E007F;
-  src: url("./CountryFlagsPolyfill.woff2") format('woff2');
+  src: url("./CountryFlagsPolyfill.woff2") format("woff2");


if we used Noto Color Emoji we could embed it without shipping the binary file in the repo

We dont need to include all emojis though, we only need the flags.

its-miroma · 2025-02-03T01:53:13Z

contributing.md

-# Contribution Guidelines {#contributing}
-


every single markdown file will have at least a two-line diff.

I've also deleted some contributing files which slipped through in versions

its-miroma added needs-discussion Further discussion is needed framework Related to the website's framework (Vitepress) stage:verification This should be verified labels Jan 22, 2025

its-miroma requested review from a team as code owners January 22, 2025 21:17

its-miroma requested a review from modmuss50 January 22, 2025 21:19

modmuss50 previously approved these changes Jan 22, 2025

View reviewed changes

its-miroma dismissed modmuss50’s stale review via 4effe9c January 22, 2025 21:36

its-miroma requested a review from modmuss50 January 22, 2025 21:39

its-miroma added stage:ready This is ready to be merged and removed stage:verification This should be verified labels Jan 22, 2025

its-miroma commented Jan 24, 2025

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

.github/workflows/publish.yml Show resolved Hide resolved

its-miroma force-pushed the framework branch 8 times, most recently from 72c82cf to 0bb0c0d Compare January 26, 2025 20:23

its-miroma commented Jan 26, 2025

View reviewed changes

.github/workflows/publish.yml Show resolved Hide resolved

IMB11 previously approved these changes Jan 31, 2025

View reviewed changes

its-miroma marked this pull request as draft February 1, 2025 00:06

its-miroma added 6 commits February 2, 2025 20:43

Update .github/CODEOWNERS

f2ceb80

Add conditions to avoid "Run failed" mails

ddf3027

Add "Cleanup" job

409ff33

Fix if condition

437034f

Upgrade runs-on to ubuntu-24.04

00ef747

its-miroma force-pushed the framework branch from a7affd5 to 00ef747 Compare February 2, 2025 19:44

its-miroma added 7 commits February 2, 2025 22:26

add a footer

f445362

add new markdownlint rules

3740880

- `incorrect-mod-id` - `no-horizontal-rules` - `no-html-line-breaks` - `no-trailing-punctuation-in-lists` - TODO: `max-one-sentence-per-line` --- - don't lint `versions` at all

enable lazy loading of images

19902d3

format everything

75a7a4a

add more recommended extensions

d12fc72

add h1 heading automatically from frontmatter

138ebdb

prepare for localization in update

7677aa4

its-miroma dismissed IMB11’s stale review via 7677aa4 February 2, 2025 21:56

its-miroma added 2 commits February 3, 2025 01:19

format all files

03bb1e6

lint translated

a670d5f

its-miroma marked this pull request as ready for review February 3, 2025 01:23

its-miroma changed the title ~~Framework updates~~ Too many updates Feb 3, 2025

its-miroma commented Feb 3, 2025

View reviewed changes

its-miroma added stage:verification This should be verified and removed stage:ready This is ready to be merged labels Feb 3, 2025

fix FabricMC#272

859bd94

its-miroma linked an issue Feb 3, 2025 that may be closed by this pull request

missing codeblock in Block States #272

Open

its-miroma added 2 commits February 3, 2025 03:45

override default margin of VPHome

f2f554e

npm audit fix

145c9ae

its-miroma requested review from a team and removed request for modmuss50 February 3, 2025 08:36

some more fixes

4fc916d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Too many updates #270

Too many updates #270

its-miroma commented Jan 22, 2025 •

edited

Loading

netlify bot commented Jan 22, 2025 •

edited

Loading

its-miroma left a comment

its-miroma Feb 3, 2025 •

edited

Loading

its-miroma Feb 3, 2025 •

edited

Loading

its-miroma Feb 3, 2025 •

edited

Loading

its-miroma Feb 3, 2025

IMB11 Feb 7, 2025

its-miroma Feb 7, 2025

its-miroma Feb 3, 2025

IMB11 Feb 3, 2025

its-miroma Feb 3, 2025

Too many updates #270

Are you sure you want to change the base?

Too many updates #270

Conversation

its-miroma commented Jan 22, 2025 • edited Loading

netlify bot commented Jan 22, 2025 • edited Loading

✅ Deploy Preview for nimble-elf-d9d491 ready!

its-miroma left a comment

Choose a reason for hiding this comment

its-miroma Feb 3, 2025 • edited Loading

Choose a reason for hiding this comment

its-miroma Feb 3, 2025 • edited Loading

Choose a reason for hiding this comment

its-miroma Feb 3, 2025 • edited Loading

Choose a reason for hiding this comment

its-miroma Feb 3, 2025

Choose a reason for hiding this comment

IMB11 Feb 7, 2025

Choose a reason for hiding this comment

its-miroma Feb 7, 2025

Choose a reason for hiding this comment

its-miroma Feb 3, 2025

Choose a reason for hiding this comment

IMB11 Feb 3, 2025

Choose a reason for hiding this comment

its-miroma Feb 3, 2025

Choose a reason for hiding this comment

its-miroma commented Jan 22, 2025 •

edited

Loading

netlify bot commented Jan 22, 2025 •

edited

Loading

its-miroma Feb 3, 2025 •

edited

Loading

its-miroma Feb 3, 2025 •

edited

Loading

its-miroma Feb 3, 2025 •

edited

Loading