Add a method for mod dependent mixins #524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Sep 25, 2021
src/main/java/net/fabricmc/loader/impl/metadata/V1ModMetadataParser.java
Show resolved
Hide resolved
liach
reviewed
Sep 29, 2021
src/main/java/net/fabricmc/loader/impl/metadata/V1ModMetadataParser.java
Show resolved
Hide resolved
In future it might want to be an object for example, this keeps the option available to do so
liach
approved these changes
Oct 3, 2021
|
I do think having version ranges is something that would be worth having. One use case would be for handling diffrent game versions. |
|
I plan on having something like it, but only alongside the metadata version bump I'm working on (brings a bunch of other additions too) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #68
Just an idea to save people needing mixin plugins for mixins that depend on other mods in a way that doesn't need changes within Mixin itself. Not the prettiest passing
FabricLoaderin, but it was the best I could come up with (given it's an internal interface anyway). Did consider allowing full dependency ranges rather than just "is the mod present" but didn't want to over invest time in something that might not be what we want anyway.