Rename SculkShriekerWarningManager#canIncreaseWarningLevel to isWardenNearby
#3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riekerWarningManager#isWardenNearby in
Shnupbups
added
refactor
Shnupbups
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the
canIncreaseWarningLevel()method ofSculkShriekerWarningManagersuggests the opposite of what it is actually used for, and is overbroad.This method is used in
warnNearbyPlayers()to prevent shriekers from spawning multiple wardens if other wardens are nearby. It returnstrueif there are any Wardens within a 48x48x48 box around the given position in the world, and false if there are none. When it returnstrue, thenwarnNearbyPlayers()will fail. However, the current name suggests thatwarnNearbyPlayers()should only fail ifcanIncreaseWarningLevel()returns false.It is also a bit overbroad, as there are other conditions that are checked to see if a sculk shrieker will warn a player or not, so this PR fixes these issues by renaming the method to
isWardenNearbyto better reflect both what the method actually does and is used for.