More block state flag changes #4110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix unpicks not being set for `StructureTemplate` methods (unpick definition file hadn't been updated to reflect the rename from `Structure`, as well as an additional method) - Rename some flags to be more accurate - Rename BlockEntity#onStateReplaced to onBlockReplaced to reflect it only being called when the actual block is changed, not just when a state change is made
apple502j
approved these changes
Feb 7, 2025
lovexyn0827
pushed a commit
to lovexyn0827/yarn
that referenced
this pull request
Feb 11, 2025
- Fix unpicks not being set for `StructureTemplate` methods (unpick definition file hadn't been updated to reflect the rename from `Structure`, as well as an additional method) - Rename some flags to be more accurate - Rename BlockEntity#onStateReplaced to onBlockReplaced to reflect it only being called when the actual block is changed, not just when a state change is made
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StructureTemplatemethods (unpick definition file hadn't been updated to reflect the rename fromStructure, as well as an additional method)