Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port of DynamicFluidContainerModel #140

Open
wants to merge 4 commits into
base: 1.21.1
Choose a base branch
from

Conversation

Salandora
Copy link

I ported the DynamicFluidContainerModel with some limitations/changes.

Notes

  • I implemented a LazyBakedModel because there was no way to get the ResourceLocation of fluids from FluidVariantRendering/FluidRenderHandlerRegistry
  • I choose to go with the FluidVariantRendering as it has its own handlers and has a fallback to FluidRenderHandler
  • It was necessary to implement the emitItemQuads/emitBlockQuads functions in the CompositeModel.Baked class so it would not fallback to using getQuads

Known problems

  • Luminous fluids light up but do get a shadow on them when rotating
  • The port relies on being rendered through fabrics rendering api as otherwise water like textures would make the items see through when hold in hand.

Fixes

  • The ModelBuilder.Simple add functions never emitted anything, leading to a reset the next time the add functions were called

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant