Update AngularJS from 1.1.2 to 1.8.2 #2190
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated AngularJS from 1.1.2 to the final version, 1.8.2 - and I've updated the menus to migrate to this latest version.
Testing in both CEF (x86-64 branch) and Awesomium (main branch) on Windows 10 and it appears to be functional in both. I have resolved any bugs that I encountered. Further testing from more users would be useful and appreciated.
Would be good to know if users on lower performing devices can notice performance improvements. There are no changes to functionality or design.
Implementation notes and explanations:
$compileProvider.debugInfoEnabled( false );
line. But this line should remain in-place when released.<a>
elements withng-click
have had an emptyhref
attribute added. This was done automatically in 1.1.2 but needed to be done manually here. These are required for CSS styling to apply properly to javascript links, such as the pointer finger cursor. Not needed on other elements or hyperlinks that useng-href
While I believe this to be bug-free and shippable, I think it would be best to get confirmation from more people that they've experienced no issues before merging. There are likely specific cases or features I don't use that I haven't fully tested.
Other contributors are very welcome to add improvements.