Merge pull request #962 from WhoSoup/factomize-reverse_badrequest

Reversing API status code
FactomProject · Feb 4, 2020 · 3e1691b · 3e1691b
2 parents c0f29f1 + acc9984
commit 3e1691b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/wsapi/debugapi.go b/wsapi/debugapi.go
@@ -30,7 +30,7 @@ func HandleDebug(writer http.ResponseWriter, request *http.Request) {
 	state, err := GetState(request)
 	if err != nil {
 		wsDebugLog.Errorf("failed to extract port from request: %s", err)
-		writer.WriteHeader(http.StatusOK)
+		writer.WriteHeader(http.StatusBadRequest)
 		return
 	}
 

diff --git a/wsapi/wsapi.go b/wsapi/wsapi.go
@@ -133,7 +133,7 @@ func returnV1Msg(writer http.ResponseWriter, msg string, success bool) {
 }
 
 func handleV1Error(writer http.ResponseWriter, err *primitives.JSONError) {
-	writer.WriteHeader(http.StatusOK)
+	writer.WriteHeader(http.StatusBadRequest)
 	return
 }
 

diff --git a/wsapi/wsapiV1.go b/wsapi/wsapiV1.go
@@ -64,7 +64,7 @@ func checkHttpPasswordOkV1(writer http.ResponseWriter, request *http.Request) bo
 		}
 	} else {
 		wsLog.Errorf("failed to get state from request: %s", err)
-		writer.WriteHeader(http.StatusOK)
+		writer.WriteHeader(http.StatusBadRequest)
 		return false
 	}
 	return true

diff --git a/wsapi/wsapiV2.go b/wsapi/wsapiV2.go
@@ -41,7 +41,7 @@ func HandleV2(writer http.ResponseWriter, request *http.Request) {
 	state, err := GetState(request)
 	if err != nil {
 		wsLog.Errorf("failed to extract port from request: %s", err)
-		writer.WriteHeader(http.StatusOK)
+		writer.WriteHeader(http.StatusBadRequest)
 		return
 	}
 
@@ -520,7 +520,7 @@ func HandleV2Error(writer http.ResponseWriter, j *primitives.JSON2Request, jErr
 	}
 	resp.Error = jErr
 
-	writer.WriteHeader(http.StatusOK)
+	writer.WriteHeader(http.StatusBadRequest)
 	_, err := writer.Write([]byte(resp.String()))
 	if err != nil {
 		wsLog.Errorf("failed to write error response: %v", err)
-Original file line number
+Diff line change
@@ Expand Up @@
     }
     func handleV1Error(writer http.ResponseWriter, err *primitives.JSONError) {
-    	writer.WriteHeader(http.StatusOK)
+    	writer.WriteHeader(http.StatusBadRequest)
     	return
     }
@@ Expand Down @@