Return status code 200 for JSONRPC errors in the factomd api #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackdump
changed the base branch from
FD-1112_a4_rollup
to
FD-1224_set_200_status_on_rpc_errors
stackdump
merged commit 8b591a0
into
FactomProject:FD-1224_set_200_status_on_rpc_errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #893
This is an inconsistency of the jsonrpc spec. the tl;dr is that all responses with valid jsonrpc formatting should receive a status code of 200, including jsonrpc errors. At the moment, the factom client does not actually check the status code of responses at all.
This may have unintended side effects if there are libraries out there that wrongly depend on the http status code to detect if a json response is an error or not.
This PR replaces all Status code 400 responses with status code 200 and updates the V1 unit test to check for an RPC error instead of the status code.