fixed aws template

FacuDeLorenzo · May 20, 2024 · d4540af · d4540af
1 parent dcaf0b7
commit d4540af
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 13 deletions.
diff --git a/packages/api/src/products.ts b/packages/api/src/products.ts
@@ -43,7 +43,6 @@ exports.get = async (
       ExclusiveStartKey: lastKey,
     });
     const response = await docClient.send(command);
-    console.log('response: ', response);
 
     const products: ProductDTO[] = response.Items.map((x) => ({
       id: x.productId,

diff --git a/packages/api/template.yaml b/packages/api/template.yaml
@@ -5,9 +5,19 @@ Description: Api
 Globals:
   Function:
     Timeout: 10
-    Role: !GetAtt ExecutionRole.Arn
 
 Resources:
+  ExecutionRole:
+    Type: AWS::IAM::Role
+    Properties: 
+      AssumeRolePolicyDocument: Json
+      RoleName: APIExecutionRole
+      Policies: 
+        - DynamoDBCrudPolicy:
+          TableName: wakeup-challenge-orders
+        - DynamoDBCrudPolicy:
+          TableName: wakeup-challenge-products
+
   MyApi:
     Type: AWS::Serverless::Api
     Properties:
@@ -25,6 +35,7 @@ Resources:
       Handler: products.get
       Runtime: nodejs20.x
       MemorySize: 128
+      Role: !GetAtt ExecutionRole.Arn
       Events:
         Event:
           Type: Api
@@ -40,6 +51,7 @@ Resources:
       Handler: orders.create
       Runtime: nodejs20.x
       MemorySize: 128
+      Role: !GetAtt ExecutionRole.Arn
       Events:
         Event:
           Type: Api
@@ -55,6 +67,7 @@ Resources:
       Handler: orders.finish
       Runtime: nodejs20.x
       MemorySize: 128
+      Role: !GetAtt ExecutionRole.Arn
       Events:
         Event:
           Type: Api
@@ -70,6 +83,7 @@ Resources:
       Handler: orders.get
       Runtime: nodejs20.x
       MemorySize: 128
+      Role: !GetAtt ExecutionRole.Arn
       Events:
         Event:
           Type: Api
@@ -85,21 +99,11 @@ Resources:
       Handler: restaurants.get
       Runtime: nodejs20.x
       MemorySize: 128
+      Role: !GetAtt ExecutionRole.Arn
       Events:
         Event:
           Type: Api
           Properties:
             Method: GET
             Path: /restaurants
             RestApiId: !Ref MyApi
-
-  ExecutionRole:
-    Type: AWS::IAM::Role
-    Properties: 
-      AssumeRolePolicyDocument: Json
-      RoleName: APIExecutionRole
-      Policies: 
-        - DynamoDBCrudPolicy:
-          TableName: wakeup-challenge-orders
-        - DynamoDBCrudPolicy:
-          TableName: wakeup-challenge-products