Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): remove render functions #95

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

IanEdington
Copy link
Contributor

@IanEdington IanEdington commented Feb 24, 2023

@IanEdington IanEdington changed the base branch from main to main-v4 February 24, 2023 02:22
@IanEdington IanEdington changed the title ian/remove render function from v4 feat(utils): remove render functions Feb 24, 2023
@IanEdington IanEdington marked this pull request as ready for review February 24, 2023 02:23
@IanEdington IanEdington force-pushed the ian/remove-render-function-from-v4 branch from 8de8aed to 290a554 Compare February 24, 2023 02:29
Comment on lines -127 to -132
{
keepComments: false,
beautify: false,
minify: true,
validationLevel: 'strict'
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer true

Comment on lines -183 to -185
## Limitations

Currently `mjml` and `@faire/mjml-react` libraries are meant to be run inside a node.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer true

Comment on lines -175 to -180
fixConditionalComment(
"<!--[if mso]><div>Hello World</div><![endif]-->",
"Hello",
"if IE"
);
// <!--[if IE]><div>Hello World</div><![endif]-->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't exist any more

@IanEdington IanEdington merged commit 91423bf into main-v4 Feb 24, 2023
@IanEdington IanEdington deleted the ian/remove-render-function-from-v4 branch February 24, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants