-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document new vector api #62
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe update enhances the Cypher query language documentation with the new Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- cypher/functions.md (1 hunks)
- cypher/index.md (1 hunks)
Additional context used
Markdownlint
cypher/index.md
203-203: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
Additional comments not posted (2)
cypher/index.md (1)
202-210
: Clarify the description of vector index options.The description of the options is clear, but ensure that the default values for optional parameters are explicitly stated, as they are crucial for users configuring the index.
Tools
Markdownlint
203-203: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
cypher/functions.md (1)
217-217
: LGTM! The functionvec.cosineDistance
is well-documented.The addition of
vec.cosineDistance
is clear and consistent with the existing documentation format.
``` | ||
{ | ||
dimension: INT, // Requiered, length of the vector to be indexed | ||
similarityFunction: STRING, // Requiered, currently only euclidean is allowed | ||
M: INT, // Optional, maximum number of outgoing edges per node. default 16 | ||
efConstruction: INT, // Optional, number of candidates during construction. default 200 | ||
efRuntime: INT // Optional, number of candidates during search. default 10 | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add language specification to the fenced code block.
The fenced code block for the options should specify a language for better syntax highlighting.
-```
+```json
Tools
Markdownlint
203-203: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
Summary by CodeRabbit
vec.cosineDistance(_vector_, _vector_)
function for computing the Cosine distance between vectors, enhancing vector operation capabilities.cosineDistance
method added for calculating distances, extending functionality in mathematical or data processing contexts.