Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of minor issues related to the casting VM #654

Merged
merged 3 commits into from
May 11, 2024
Merged

Conversation

object-Object
Copy link
Member

@object-Object object-Object commented Apr 22, 2024

@object-Object object-Object requested a review from Alwinfy April 22, 2024 16:10
@Talia-12
Copy link
Member

The double copy of newImage.withResetEscape().copy(stack = tStack) is mildly unideal, might be better to allow the withResetEscape method to accept args like stack so you can do newImage.withResetEscape(stack = tStack) and pass that through to the copy inside withResetEscape so you only copy once? no idea if that is actually possible to do

@object-Object
Copy link
Member Author

image

@object-Object object-Object merged commit 1eb1187 into main May 11, 2024
3 checks passed
@object-Object object-Object deleted the vm-fixes branch May 11, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evanition doesn't quite work right. It erases, but also ends the introspection
2 participants