Simplify and cleanup CSS and improve initial load performance #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fannon
changed the title
Fannon
force-pushed
the
simplify-css-reset
branch
from
8578693
to
b0ae6f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using https://www.joshwcomeau.com/css/custom-css-reset/ instead of CSS minireset library
Cleaned up and simplified CSS, hopefully it's not just smaller but also more performant.
I used to write it with SCSS, which led to a few unnecessary nested selectors.
This will also lazy-load some CSS that is only needed when tagging bookmarks or going to options.