Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add termination condition based on percentage of visited tiles for Car Racing #1323

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VincenzoPalma
Copy link

Description

The environment will now end with terminated = True when the lap is completed after reaching the specified percentage of visited tiles.

Fixes #1269

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • I have made corresponding changes to the documentation

@pseudo-rnd-thoughts
Copy link
Member

@VincenzoPalma To clarify what was the previous behaviour when the agent had cross that the lap completion percentage and got to the end?

Could you train an agent using PPO from SB3 and share the training graphes of the old and new versions?

@VincenzoPalma
Copy link
Author

@pseudo-rnd-thoughts The previous behavior in that scenario was that the environment would not terminate upon completing the lap but would instead continue until reaching the time limit, at which point it would end with truncated = True.

I will try and train an agent as you suggest as soon as i can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] "CarRacing-v3" Appears to Reset before Completing a Lap causing it to Ignore lap_complete_percent
2 participants