feat(client): update payment installments types

Farfetch · Sep 15, 2023 · e4db4fb · e4db4fb
1 parent 88ead15
commit e4db4fb
Show file tree

Hide file tree

Showing 16 changed files with 41 additions and 1 deletion.
diff --git a/packages/client/src/payments/types/paymentInstrument.types.ts b/packages/client/src/payments/types/paymentInstrument.types.ts
@@ -5,6 +5,10 @@ import type {
   ShopperInteraction,
 } from './index.js';
 
+export type InstrumentInstallment = {
+  quantity: number;
+};
+
 export enum PaymentInstrumentStatus {
   Created = 'Created',
   Pending = 'Pending',

diff --git a/packages/client/src/payments/types/paymentMethods.types.ts b/packages/client/src/payments/types/paymentMethods.types.ts
@@ -22,7 +22,9 @@ export type CreditCard = {
 
 export type CreditCardPaymentMethod = {
   type: string;
-  creditCards: CreditCard[];
+  creditCards?: CreditCard[];
+  supportsInstallments?: boolean;
+  installments?: number[];
 };
 
 export type PaymentMethods = {

diff --git a/packages/client/src/payments/types/postPaymentIntentInstrument.types.ts b/packages/client/src/payments/types/postPaymentIntentInstrument.types.ts
@@ -1,5 +1,6 @@
 import type {
   Amounts,
+  InstrumentInstallment,
   Issuer,
   PayerAddressType,
   PayerInput,
@@ -50,6 +51,7 @@ export type PostPaymentIntentInstrumentData = {
   payer?: PayerInput;
   amounts: Amounts[];
   data?: CreatePaymentInstrumentData;
+  installments?: InstrumentInstallment;
   shopperInteraction?: ShopperInteraction;
 };
 

diff --git a/packages/client/src/payments/types/putPaymentIntentInstrument.types.ts b/packages/client/src/payments/types/putPaymentIntentInstrument.types.ts
@@ -1,5 +1,6 @@
 import type {
   Amounts,
+  InstrumentInstallment,
   PayerAddressType,
   PayerInput,
   PaymentInstrument,
@@ -12,6 +13,7 @@ export type PutPaymentIntentInstrumentData = {
   createToken?: boolean;
   payer?: PayerInput;
   amounts: Amounts[];
+  installments?: InstrumentInstallment;
   shopperInteraction?: ShopperInteraction;
   payerAddressType?: PayerAddressType;
 };

diff --git a/packages/redux/src/checkout/actions/__tests__/__snapshots__/createCheckoutOrder.test.ts.snap b/packages/redux/src/checkout/actions/__tests__/__snapshots__/createCheckoutOrder.test.ts.snap
@@ -40,6 +40,8 @@ Object {
                   "id": "",
                 },
               ],
+              "installments": Array [],
+              "supportsInstallments": false,
               "type": "",
             },
             "customerAccounts": Array [],

diff --git a/packages/redux/src/checkout/actions/__tests__/__snapshots__/fetchCheckoutOrder.test.ts.snap b/packages/redux/src/checkout/actions/__tests__/__snapshots__/fetchCheckoutOrder.test.ts.snap
@@ -40,6 +40,8 @@ Object {
                   "id": "",
                 },
               ],
+              "installments": Array [],
+              "supportsInstallments": false,
               "type": "",
             },
             "customerAccounts": Array [],

diff --git a/...rc/checkout/actions/__tests__/__snapshots__/fetchCheckoutOrderPaymentMethods.test.ts.snap b/...rc/checkout/actions/__tests__/__snapshots__/fetchCheckoutOrderPaymentMethods.test.ts.snap
@@ -50,6 +50,8 @@ Object {
                   "id": "e13bb06b-392b-49a0-8acd-3f44416e3234",
                 },
               ],
+              "installments": Array [],
+              "supportsInstallments": false,
               "type": "CreditCard",
             },
             "customerAccounts": Array [
@@ -148,6 +150,8 @@ Object {
             "id": "e13bb06b-392b-49a0-8acd-3f44416e3234",
           },
         ],
+        "installments": Array [],
+        "supportsInstallments": false,
         "type": "CreditCard",
       },
       "customerAccounts": Array [

diff --git a/...x/src/checkout/actions/__tests__/__snapshots__/removeCheckoutOrderPromocodes.test.ts.snap b/...x/src/checkout/actions/__tests__/__snapshots__/removeCheckoutOrderPromocodes.test.ts.snap
@@ -40,6 +40,8 @@ Object {
                   "id": "",
                 },
               ],
+              "installments": Array [],
+              "supportsInstallments": false,
               "type": "",
             },
             "customerAccounts": Array [],

diff --git a/.../redux/src/checkout/actions/__tests__/__snapshots__/setCheckoutOrderItemTags.test.ts.snap b/.../redux/src/checkout/actions/__tests__/__snapshots__/setCheckoutOrderItemTags.test.ts.snap
@@ -40,6 +40,8 @@ Object {
                   "id": "",
                 },
               ],
+              "installments": Array [],
+              "supportsInstallments": false,
               "type": "",
             },
             "customerAccounts": Array [],

diff --git a/...edux/src/checkout/actions/__tests__/__snapshots__/setCheckoutOrderPromocodes.test.ts.snap b/...edux/src/checkout/actions/__tests__/__snapshots__/setCheckoutOrderPromocodes.test.ts.snap
@@ -40,6 +40,8 @@ Object {
                   "id": "",
                 },
               ],
+              "installments": Array [],
+              "supportsInstallments": false,
               "type": "",
             },
             "customerAccounts": Array [],

diff --git a/...ages/redux/src/checkout/actions/__tests__/__snapshots__/setCheckoutOrderTags.test.ts.snap b/...ages/redux/src/checkout/actions/__tests__/__snapshots__/setCheckoutOrderTags.test.ts.snap
@@ -40,6 +40,8 @@ Object {
                   "id": "",
                 },
               ],
+              "installments": Array [],
+              "supportsInstallments": false,
               "type": "",
             },
             "customerAccounts": Array [],

diff --git a/packages/redux/src/checkout/actions/__tests__/__snapshots__/updateCheckoutOrder.test.ts.snap b/packages/redux/src/checkout/actions/__tests__/__snapshots__/updateCheckoutOrder.test.ts.snap
@@ -40,6 +40,8 @@ Object {
                   "id": "",
                 },
               ],
+              "installments": Array [],
+              "supportsInstallments": false,
               "type": "",
             },
             "customerAccounts": Array [],
@@ -484,6 +486,8 @@ Object {
                   "id": "",
                 },
               ],
+              "installments": Array [],
+              "supportsInstallments": false,
               "type": "",
             },
             "customerAccounts": Array [],

diff --git a/...ents/actions/__tests__/__snapshots__/fetchPaymentMethodsByCountryAndCurrency.test.ts.snap b/...ents/actions/__tests__/__snapshots__/fetchPaymentMethodsByCountryAndCurrency.test.ts.snap
@@ -46,6 +46,8 @@ Object {
           "id": "e13bb06b-392b-49a0-8acd-3f44416e3234",
         },
       ],
+      "installments": Array [],
+      "supportsInstallments": false,
       "type": "CreditCard",
     },
     "customerAccounts": Array [

diff --git a/...dux/src/payments/actions/__tests__/__snapshots__/fetchPaymentMethodsByIntent.test.ts.snap b/...dux/src/payments/actions/__tests__/__snapshots__/fetchPaymentMethodsByIntent.test.ts.snap
@@ -46,6 +46,8 @@ Object {
           "id": "e13bb06b-392b-49a0-8acd-3f44416e3234",
         },
       ],
+      "installments": Array [],
+      "supportsInstallments": false,
       "type": "CreditCard",
     },
     "customerAccounts": Array [

diff --git a/tests/__fixtures__/checkout/checkout.fixtures.mts b/tests/__fixtures__/checkout/checkout.fixtures.mts
@@ -435,6 +435,8 @@ export const mockResponse = {
     creditCard: {
       type: '',
       creditCards: [{ id: '', description: '', code: '' }],
+      supportsInstallments: false,
+      installments: [],
     },
   },
   userPaymentTokens: undefined,
@@ -928,6 +930,8 @@ export const mockUpdateCheckoutResponse = {
               code: '',
             },
           ],
+          supportsInstallments: false,
+          installments: [],
         },
       },
       orderStatus: OrderStatusError.NoError,

diff --git a/tests/__fixtures__/payments/payments.fixtures.mts b/tests/__fixtures__/payments/payments.fixtures.mts
@@ -336,6 +336,8 @@ export const mockFetchPaymentMethodsResponse = {
         code: 'VISA',
       },
     ],
+    supportsInstallments: false,
+    installments: [],
   },
 };
 export const mockFetchPaymentIntentChargeResponse = {