-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add middleware for getting the wishlist sets upon shared wishlist id changes #847
feat(core): add middleware for getting the wishlist sets upon shared wishlist id changes #847
Conversation
...ges/core/src/sharedWishlists/redux/middlewares/getWishlistSetsUponSharedWishlistIdChanges.js
Show resolved
Hide resolved
Also there is a problem I have just noticed in the implementation, at least in |
1cd3837
to
ea14909
Compare
The scope of this PR has been changed as it now adds an action to the |
ea14909
to
29c6c00
Compare
packages/core/src/sharedWishlists/redux/__tests__/reducer.test.js
Outdated
Show resolved
Hide resolved
packages/core/src/sharedWishlists/redux/__tests__/reducer.test.js
Outdated
Show resolved
Hide resolved
29c6c00
to
7b0a421
Compare
Description
This adds a middleware for getting the wishlist sets when the
sharedWishlistId
has changed. It ensures we are always accessing the updated data from the wishlist sets after creating or deleting a shared wishlist.Also, the action
UPDATE_WISHLIST_SET_SUCCESS
was added to theupdateSharedWishlistUponItemsChanges
middleware and the shared wishlist reducer (result) was adjusted.Dependencies
None
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement