Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redux): add share wishlist middleware for refetching wishlist sets #851

Conversation

danpadrinom
Copy link
Contributor

@danpadrinom danpadrinom commented Aug 29, 2023

Description

This adds a middleware for getting the wishlist sets when the sharedWishlistId has changed. It ensures we are always accessing the updated data from the wishlist sets after creating or deleting a shared wishlist.

Also, the action UPDATE_WISHLIST_SET_SUCCESS was added to the updateSharedWishlistUponItemsChanges middleware.

Dependencies

None

Checklist

  • The commit message follows our guidelines
  • Tests for the respective changes have been added
  • The code is commented, particularly in hard-to-understand areas
  • The labels and/or milestones were added

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@danpadrinom danpadrinom added type: feature New feature 📦 redux Relative to the `@farfetch/blackout-redux` package labels Aug 29, 2023
@danpadrinom danpadrinom added this to the dev-main-29-08-23 milestone Aug 29, 2023
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Aug 29, 2023
@ruifcnunes ruifcnunes merged commit cfd8eb8 into dev-main-29-08-23 Aug 30, 2023
4 checks passed
@ruifcnunes ruifcnunes deleted the feat_add-shared-wishlist-middleware-for-refetching-wishlist-sets branch August 30, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 redux Relative to the `@farfetch/blackout-redux` package type: feature New feature
Development

Successfully merging this pull request may close these issues.

3 participants